You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 02:58:40 UTC

[GitHub] [skywalking] lijial opened a new issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

lijial opened a new issue #6095:
URL: https://github.com/apache/skywalking/issues/6095


   Dear skywalking team
   My link is rest http servlet, in http method call ThreadPoolTaskExecutor.execute(new Runnable()).
   
   When I use skywalking, I notice there is no Runnable trace in UI result , there's only http method as pic show.
   ![image](https://user-images.githubusercontent.com/4213303/103255507-85138a00-49c4-11eb-91f8-c77d5f616581.png)
   
   My question is, is this the correct result in skywalking ? in http request, the Runnable method in ThreadPoolTaskExecutor.executor() dose not show? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6095:
URL: https://github.com/apache/skywalking/issues/6095


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6095:
URL: https://github.com/apache/skywalking/issues/6095#issuecomment-751936465


   Read `If you want to continue traces across thread manually, use across thread solution APIs.` doc in the agent setup doc, https://github.com/apache/skywalking/blob/v8.3.0/docs/en/setup/service-agent/java-agent/README.md#advanced-features-1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6095:
URL: https://github.com/apache/skywalking/issues/6095#issuecomment-751967262


   They provided `RunnableWrapper.of` for you. Thread is widely used, agent can't do the dark magic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] lijial edited a comment on issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6095:
URL: https://github.com/apache/skywalking/issues/6095#issuecomment-751964225


   @wu-sheng I see, this method could solve threadpool monitor. But this could make so very invasive to business code compare with only  **-javaagent**  jvm parameters. 
   For if I new Runnable() with Anonymous object, I could not use @TraceCrossThread annotation. Only I should do is to try implemetation of Runnable and put it to threadpool. A little complex to use I think.
   What I thought is correct and comprehensive?And is there any solution for easy monitor threadpool?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] lijial commented on issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6095:
URL: https://github.com/apache/skywalking/issues/6095#issuecomment-751964225


   @wu-sheng I see, this method could solve threadpool monitor. But this could make so very invasive to business code compare with only  -javaagent  jvm parameters. 
   For if I new Runnable() with Anonymous object, I could not use @TraceCrossThread annotation. Only I should do is to try implemetation of Runnable and put it to threadpool. A little complex to use I think.
   Am I think is correct and comprehensive?And is there any solution for easy monitor threadpool?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] lijial edited a comment on issue #6095: ThreadPoolTaskExecutor.executor(new Runnable()) done not show in skywalking UI

Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6095:
URL: https://github.com/apache/skywalking/issues/6095#issuecomment-751964225


   @wu-sheng I see, this method could solve threadpool monitor. But this could make so very invasive to business code compare with only  **-javaagent**  jvm parameters. 
   For if I new Runnable() with Anonymous object, I could not use @TraceCrossThread annotation. Only I should do is to try implemetation of Runnable and put it to threadpool. A little complex to use I think.
   Am I think is correct and comprehensive?And is there any solution for easy monitor threadpool?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org