You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/02/02 23:14:53 UTC
[GitHub] [geode] Bill opened a new pull request #7336: DRAFT NO MERGE: Latest support/1.13 sans ByteBuffer sharing framework
Bill opened a new pull request #7336:
URL: https://github.com/apache/geode/pull/7336
Started from latest support/1.13 and then reverted these commits:
```
c0d138f05738782da84a3e9fbdda74fc779e3ab3 GEODE-9825 processInputBuffer resize retains data
4ef2bcd4962bc9506c2b7eec2fdab8467759488f GEODE-9141 (1) Handle in-buffer concurrency
f28eca3ad926f4f8f9c481426260f8f8ddc2dc9a GEODE-9141 (2) ditto
32a8a55df4c0a5b8b1e5cfb746070804cbce5e0a GEODE-8652 NioSslEngine.close() bypasses locks
```
To make it compile I manually added in some `Thread.yield()`s and eliminated some exceptions in throws clauses à la GEODE-9380.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7336: DRAFT NO MERGE: Latest support/1.13 sans ByteBuffer sharing framework
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7336:
URL: https://github.com/apache/geode/pull/7336#issuecomment-1028466893
This pull request **introduces 4 alerts** when merging 00caa4b58e787152a645059ff5db10c36d91771f into d2595701d1c7c905cf676b6eb233dc569537c654 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-0dd03266ea2581ae1cbf985deb30339644bcc35a)
**new alerts:**
* 3 for Potential input resource leak
* 1 for Potential output resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org