You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 14:11:36 UTC
[GitHub] [airflow] Bruschkov opened a new pull request #7153: [AIRFLOW-5117]
Fixed Bug with ISO-8601 Timestamps
Bruschkov opened a new pull request #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153
#JIRA
https://issues.apache.org/jira/browse/AIRFLOW-5117
# Description
When using the KubernetesPodOperator on an aws kubernetes cluster, the aws-iam-authenticator is used to obatin kubernetes authentication tokens. The aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting the "Z" timezone into a regular +0000 format.
# Test Coverage
Not Needed, very minor fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
========================================
Coverage ? 85.4%
========================================
Files ? 710
Lines ? 39484
Branches ? 0
========================================
Hits ? 33723
Misses ? 5761
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `76.78% <83.33%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...ce626e1](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-574201470
> I'd still prefer to have a test for that one. This should b e rather easy to add such test.
>
> There is already the tests/kubernetes/test_client.py with two tests and adding a test there would be just great (we need to improve coverage on Kubernetes part and even really small tests like that gradually added help a lot)
>
> Would you be so nice to add it please?
Hi, thanks for your quick feedback. Added the test and amended the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-6585] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
Bruschkov commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-581286685
> Why are these changes being made in this project and not in [the Kubernetes library](https://github.com/kubernetes-client/python-base)? I can't find the ticket in the library repository.
https://github.com/apache/airflow/pull/5731#issuecomment-520271784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7153:
[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#discussion_r405448747
##########
File path: airflow/kubernetes/refresh_config.py
##########
@@ -32,6 +32,15 @@
from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader
+def _parse_timestamp(ts_str: str) -> int:
+ if ts_str[-1] == 'Z':
Review comment:
Using pendulum (which we already use) might be a better fix than this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-6585] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
Bruschkov commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-576578569
@ashb New JIRA created and linked to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
========================================
Coverage ? 85.4%
========================================
Files ? 710
Lines ? 39484
Branches ? 0
========================================
Hits ? 33723
Misses ? 5761
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `76.78% <83.33%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...ce626e1](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7153: [AIRFLOW-6585] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-581169532
Why are these changes being made in this project and not in [the Kubernetes library](https://github.com/kubernetes-client/python-base)? I can't find the ticket in the library repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5444bfe`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [5444bfe...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5444bfe`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [5444bfe...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
========================================
Coverage ? 85.4%
========================================
Files ? 710
Lines ? 39484
Branches ? 0
========================================
Hits ? 33723
Misses ? 5761
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `76.78% <83.33%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...ce626e1](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5444bfe`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [5444bfe...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7153: [AIRFLOW-5117] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-575237800
Change looks good now, but as this JIRA was already released we need a new JIRA please. (We use the Fix Version to know what to pull back to our releases, and as AIRFLOW-5117 is already released we would otherwise miss this change when building 1.10.8)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-574582795
@potiuk
Everything solved and build passes now.
Best regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5444bfe`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [5444bfe...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7153: [AIRFLOW-5117] Fixed
Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@5444bfe`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [5444bfe...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] commented on issue #7153: [AIRFLOW-6585] Fixed
Timestamp bug in RefreshKubeConfigLoader
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-610164786
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573681024
Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
Adding a new operator? Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7153:
[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7153: [AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps
URL: https://github.com/apache/airflow/pull/7153#issuecomment-573743099
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e7bf8ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7153 +/- ##
=========================================
Coverage ? 85.31%
=========================================
Files ? 707
Lines ? 39360
Branches ? 0
=========================================
Hits ? 33580
Misses ? 5780
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7153/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `71.69% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=footer). Last update [e7bf8ec...6bf555b](https://codecov.io/gh/apache/airflow/pull/7153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services