You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/23 21:49:16 UTC
[GitHub] [beam] lukecwik opened a new pull request, #24343: Update precombine bencmark to better represent varied workloads
lukecwik opened a new pull request, #24343:
URL: https://github.com/apache/beam/pull/24343
1. Represent more data distributions (hot key, uniform, normal, unique)
2. Run longer allowing the JIT to function
3. Have a random ordering of data
4. Use a blackhole to prevent to the JIT from optimizing away the data
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #24343: Update precombine bencmark to better represent varied workloads
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #24343:
URL: https://github.com/apache/beam/pull/24343#issuecomment-1325700953
R: @bhisevishal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bhisevishal commented on pull request #24343: Update precombine benchmark to better represent varied workloads
Posted by GitBox <gi...@apache.org>.
bhisevishal commented on PR #24343:
URL: https://github.com/apache/beam/pull/24343#issuecomment-1329802544
Thanks @lukecwik Looks good. Is it possible to have muti threaded benchmark as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #24343: Update precombine benchmark to better represent varied workloads
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #24343:
URL: https://github.com/apache/beam/pull/24343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24343: Update precombine bencmark to better represent varied workloads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24343:
URL: https://github.com/apache/beam/pull/24343#issuecomment-1325701913
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #24343: Update precombine benchmark to better represent varied workloads
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #24343:
URL: https://github.com/apache/beam/pull/24343#issuecomment-1329921588
> Thanks @lukecwik Looks good. Is it possible to have muti threaded benchmark as well.
I'm not sure it will provide much value but you can always [configure the benchmark](https://github.com/apache/beam/blob/135007ec6b4281d2cbcb24f271bac8e442fc4316/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1481) with the additional flag `-t 4` for running it concurrently with 4 threads or add the annotation `@Threads(4)` to the benchmark itself ([example](https://github.com/apache/beam/blob/135007ec6b4281d2cbcb24f271bac8e442fc4316/sdks/java/harness/jmh/src/main/java/org/apache/beam/fn/harness/jmh/ProcessBundleBenchmark.java#L265)).
Note that this benchmark only checks the combiner table and doesn't represent a full transform graph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org