You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/07 19:37:49 UTC
[GitHub] [superset] DavidWoolner opened a new pull request #17970: refactor(explorechartheader): convert class to functional component
DavidWoolner opened a new pull request #17970:
URL: https://github.com/apache/superset/pull/17970
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Refactored ExploreChartHeader component from class to functional.
Ticket requested both refactor to functional component as well as TypeScript conversion.
My intention is to handle the TS conversion with an additional PR.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
This is before:
This is after:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2873e17) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.02%`.
> The diff coverage is `56.41%`.
> :exclamation: Current head 2873e17 differs from pull request most recent head ceba18e. Consider uploading reports for the commit ceba18e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.32% -0.03%
==========================================
Files 1569 1569
Lines 61687 61732 +45
Branches 6241 6273 +32
==========================================
+ Hits 40927 40941 +14
- Misses 19162 19170 +8
- Partials 1598 1621 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.89% <56.41%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `48.61% <56.41%> (+2.03%)` | :arrow_up: |
| [...ugins/plugin-chart-echarts/src/Timeseries/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9pbmRleC50cw==) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Step/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9TdGVwL2luZGV4LnRz) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Area/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2luZGV4LnRz) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...-chart-echarts/src/Timeseries/Regular/Bar/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9pbmRleC50cw==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Regular/Line/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0xpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/Scatter/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1NjYXR0ZXIvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...echarts/src/Timeseries/Regular/SmoothLine/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1Ntb290aExpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...ceba18e](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/2dfcbdb08c963c1755d98d47285ed38d0642aeac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dfcbdb) will **increase** coverage by `0.18%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
+ Coverage 66.05% 66.24% +0.18%
==========================================
Files 1591 1603 +12
Lines 62423 62560 +137
Branches 6287 6322 +35
==========================================
+ Hits 41233 41440 +207
+ Misses 19568 19470 -98
- Partials 1622 1650 +28
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <64.70%> (+0.43%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `72.00% <ø> (+57.33%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.76% <64.70%> (+4.19%)` | :arrow_up: |
| [.../src/explore/components/DataTableControl/index.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sL2luZGV4LnRzeA==) | `74.28% <0.00%> (-23.09%)` | :arrow_down: |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `66.66% <0.00%> (-12.29%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `25.71% <0.00%> (-9.58%)` | :arrow_down: |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `66.66% <0.00%> (-7.25%)` | :arrow_down: |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `72.36% <0.00%> (-5.90%)` | :arrow_down: |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `58.88% <0.00%> (-4.21%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `81.25% <0.00%> (-3.75%)` | :arrow_down: |
| ... and [118 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dfcbdb...7cf7dc1](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3762845) into [master](https://codecov.io/gh/apache/superset/commit/97a78d3301b138c3daff677381f9e595c858fe32?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97a78d3) will **decrease** coverage by `0.76%`.
> The diff coverage is `62.36%`.
> :exclamation: Current head 3762845 differs from pull request most recent head 307f7b2. Consider uploading reports for the commit 307f7b2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 67.07% 66.30% -0.77%
==========================================
Files 1609 1569 -40
Lines 64903 61625 -3278
Branches 6866 6232 -634
==========================================
- Hits 43535 40863 -2672
+ Misses 19502 19162 -340
+ Partials 1866 1600 -266
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <62.36%> (-2.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-chart-controls/src/sections/advancedAnalytics.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2FkdmFuY2VkQW5hbHl0aWNzLnRzeA==) | `33.33% <ø> (ø)` | |
| [...legacy-plugin-chart-partition/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvY29udHJvbFBhbmVsLnRzeA==) | `25.00% <ø> (ø)` | |
| [...gins/legacy-plugin-chart-rose/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `50.00% <ø> (ø)` | |
| [.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Jhci9pbmRleC5qcw==) | `66.66% <ø> (ø)` | |
| [...gins/legacy-preset-chart-nvd3/src/DistBar/index.js](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Rpc3RCYXIvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [...ins/legacy-preset-chart-nvd3/src/DualLine/index.js](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0R1YWxMaW5lL2luZGV4Lmpz) | `66.66% <ø> (ø)` | |
| [...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNDb250cm9scy50c3g=) | `95.83% <ø> (ø)` | |
| [...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL1JlYWN0TlZEMy5qc3g=) | `0.00% <ø> (ø)` | |
| [...c/SqlLab/components/TemplateParamsEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yL2luZGV4LnRzeA==) | `75.00% <ø> (-9.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `25.00% <ø> (-32.15%)` | :arrow_down: |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [97a78d3...307f7b2](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] DavidWoolner commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
DavidWoolner commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r780518934
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
- renderReportModal() {
- const attachedReportExists = !!Object.keys(this.props.reports).length;
+ const renderReportModal = () => {
+ const attachedReportExists = !!Object.keys(reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
- showReportModal={this.showReportModal}
- hideReportModal={this.hideReportModal}
- toggleActive={this.props.toggleActive}
- deleteActiveReport={this.props.deleteActiveReport}
+ showReportModal={showReportModal}
Review comment:
Yes! I've made the change as requested and it seems to work fine. Should I do the same for `openPropertiesModal` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r781305078
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,138 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ const { userId } = user;
Review comment:
This will probably fail with an anonymous user
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,138 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ const { userId } = user;
+ const { id } = chart;
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ if (canAddReports()) {
+ fetchUISpecificReport(userId, 'chart_id', 'charts', id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, []);
Review comment:
It appears that some dependencies might be missing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] DavidWoolner commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
DavidWoolner commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r781491074
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,138 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ const { userId } = user;
+ const { id } = chart;
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ if (canAddReports()) {
+ fetchUISpecificReport(userId, 'chart_id', 'charts', id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, []);
Review comment:
thanks! I've added dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r780500662
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
- renderReportModal() {
- const attachedReportExists = !!Object.keys(this.props.reports).length;
+ const renderReportModal = () => {
+ const attachedReportExists = !!Object.keys(reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
- showReportModal={this.showReportModal}
- hideReportModal={this.hideReportModal}
- toggleActive={this.props.toggleActive}
- deleteActiveReport={this.props.deleteActiveReport}
+ showReportModal={showReportModal}
Review comment:
could you test something for me. Instead of having a `showReportModal` function would it look the same if we just invoke the function inside? Meaning
`showReportModal={setShowingReportModal(true)}`
and the same for hide report modal. Would it work the same? If so, let's get rid of the extra functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceba18e) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.04%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.29% -0.05%
==========================================
Files 1569 1572 +3
Lines 61687 61784 +97
Branches 6241 6285 +44
==========================================
+ Hits 40927 40961 +34
- Misses 19162 19202 +40
- Partials 1598 1621 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <57.14%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.96% <57.14%> (+0.39%)` | :arrow_up: |
| [...ugins/plugin-chart-echarts/src/Timeseries/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9pbmRleC50cw==) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Step/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9TdGVwL2luZGV4LnRz) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Area/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2luZGV4LnRz) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...-chart-echarts/src/Timeseries/Regular/Bar/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9pbmRleC50cw==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Regular/Line/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0xpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/Scatter/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1NjYXR0ZXIvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...echarts/src/Timeseries/Regular/SmoothLine/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1Ntb290aExpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...ceba18e](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.10%`.
> The diff coverage is `52.38%`.
> :exclamation: Current head 7cf7dc1 differs from pull request most recent head 75d9395. Consider uploading reports for the commit 75d9395 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.24% -0.11%
==========================================
Files 1569 1603 +34
Lines 61687 62560 +873
Branches 6241 6322 +81
==========================================
+ Hits 40927 41440 +513
- Misses 19162 19470 +308
- Partials 1598 1650 +52
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <52.38%> (+0.37%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rt-controls/src/operators/rollingWindowOperator.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9yb2xsaW5nV2luZG93T3BlcmF0b3IudHM=) | `100.00% <ø> (ø)` | |
| [...ui-chart-controls/src/operators/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/connection/SupersetClient.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29ubmVjdGlvbi9TdXBlcnNldENsaWVudC50cw==) | `100.00% <ø> (ø)` | |
| [...superset-ui-core/src/query/types/PostProcessing.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUG9zdFByb2Nlc3NpbmcudHM=) | `100.00% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `100.00% <ø> (ø)` | |
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-country-map/src/countries.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb3VudHJpZXMudHM=) | `100.00% <ø> (ø)` | |
| [...src/BigNumber/BigNumberWithTrendline/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvYnVpbGRRdWVyeS50cw==) | `9.09% <ø> (ø)` | |
| [...chart-echarts/src/MixedTimeseries/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL2NvbnRyb2xQYW5lbC50c3g=) | `80.00% <ø> (ø)` | |
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| ... and [261 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...75d9395](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1011149255
Hey @DavidWoolner if you can get the CI passing I'd be happy to launch a test env for this PR and do some manual testing. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r794759699
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,138 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ const { userId } = user;
+ const { id } = chart;
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ if (canAddReports()) {
+ fetchUISpecificReport(userId, 'chart_id', 'charts', id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, []);
Review comment:
actually this form of a useEffect emulated a ComponentWillMount which is what the original component was using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.10%`.
> The diff coverage is `52.38%`.
> :exclamation: Current head 7cf7dc1 differs from pull request most recent head febb1eb. Consider uploading reports for the commit febb1eb to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.24% -0.11%
==========================================
Files 1569 1603 +34
Lines 61687 62560 +873
Branches 6241 6322 +81
==========================================
+ Hits 40927 41440 +513
- Misses 19162 19470 +308
- Partials 1598 1650 +52
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <52.38%> (+0.37%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rt-controls/src/operators/rollingWindowOperator.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9yb2xsaW5nV2luZG93T3BlcmF0b3IudHM=) | `100.00% <ø> (ø)` | |
| [...ui-chart-controls/src/operators/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/connection/SupersetClient.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29ubmVjdGlvbi9TdXBlcnNldENsaWVudC50cw==) | `100.00% <ø> (ø)` | |
| [...superset-ui-core/src/query/types/PostProcessing.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUG9zdFByb2Nlc3NpbmcudHM=) | `100.00% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `100.00% <ø> (ø)` | |
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-country-map/src/countries.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb3VudHJpZXMudHM=) | `100.00% <ø> (ø)` | |
| [...src/BigNumber/BigNumberWithTrendline/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvYnVpbGRRdWVyeS50cw==) | `9.09% <ø> (ø)` | |
| [...chart-echarts/src/MixedTimeseries/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL2NvbnRyb2xQYW5lbC50c3g=) | `80.00% <ø> (ø)` | |
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| ... and [261 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...febb1eb](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r791344323
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
Review comment:
This function can be cleaned to one line like this:
`const getSliceName = () => sliceName || t('%s - untitled', tableName);`
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
Review comment:
```suggestion
const closePropertiesModal = () => setIsPropertiesModalOpen(false);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
Review comment:
```suggestion
const openPropertiesModal = () => setIsPropertiesModalOpen(true);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,142 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ if (canAddReports()) {
+ fetchUISpecificReport(user.userId, 'chart_id', 'charts', chart.id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, [
+ canAddReports,
+ fetchUISpecificReport,
+ user.userId,
+ chart.id,
+ dashboardId,
+ fetchChartDashboardData,
+ ]);
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ const {
+ chartStatus,
+ chartUpdateEndTime,
+ chartUpdateStartTime,
+ latestQueryFormData,
+ queriesResponse,
+ } = chart;
+ // TODO: when will get appropriate design for multi queries use all results and not first only
+ const queryResponse = queriesResponse?.[0];
+ const chartFinished = ['failed', 'rendered', 'success'].includes(
+ chart.chartStatus,
+ );
+ return (
+ <StyledHeader id="slice-header" className="panel-title-large">
+ <div className="title-panel">
+ {slice?.certified_by && (
+ <>
+ <CertifiedBadge
+ certifiedBy={slice.certified_by}
+ details={slice.certification_details}
+ />{' '}
+ </>
+ )}
+ <EditableTitle
+ title={getSliceName()}
Review comment:
```suggestion
title={getSliceName}
```
This doesn't need to be instantiated.
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
Review comment:
```suggestion
const showReportModal = () => setShowingReportModal(true);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,142 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ if (canAddReports()) {
+ fetchUISpecificReport(user.userId, 'chart_id', 'charts', chart.id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, [
+ canAddReports,
+ fetchUISpecificReport,
+ user.userId,
+ chart.id,
+ dashboardId,
+ fetchChartDashboardData,
+ ]);
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ const {
+ chartStatus,
+ chartUpdateEndTime,
+ chartUpdateStartTime,
+ latestQueryFormData,
+ queriesResponse,
+ } = chart;
+ // TODO: when will get appropriate design for multi queries use all results and not first only
+ const queryResponse = queriesResponse?.[0];
+ const chartFinished = ['failed', 'rendered', 'success'].includes(
+ chart.chartStatus,
+ );
+ return (
+ <StyledHeader id="slice-header" className="panel-title-large">
+ <div className="title-panel">
+ {slice?.certified_by && (
+ <>
+ <CertifiedBadge
+ certifiedBy={slice.certified_by}
+ details={slice.certification_details}
+ />{' '}
+ </>
+ )}
+ <EditableTitle
+ title={getSliceName()}
+ canEdit={
+ !slice ||
+ canOverwrite ||
+ (slice?.owners || []).includes(user?.userId)
+ }
+ onSaveTitle={actions.updateChartTitle}
+ />
+
+ {slice && (
+ <StyledButtons>
+ {user.userId && (
+ <FaveStar
+ itemId={slice.slice_id}
+ fetchFaveStar={actions.fetchFaveStar}
+ saveFaveStar={actions.saveFaveStar}
+ isStarred={isStarred}
+ showTooltip
+ />
+ )}
+ {isPropertiesModalOpen && (
+ <PropertiesModal
+ show={isPropertiesModalOpen}
+ onHide={closePropertiesModal}
+ onSave={sliceUpdated}
+ slice={slice}
+ />
+ )}
+ <Tooltip id="edit-desc-tooltip" title={t('Edit chart properties')}>
+ <span
+ aria-label={t('Edit chart properties')}
+ role="button"
+ tabIndex={0}
+ className="edit-desc-icon"
+ onClick={openPropertiesModal}
>
- <span
- aria-label={t('Edit chart properties')}
- role="button"
- tabIndex={0}
- className="edit-desc-icon"
- onClick={this.openPropertiesModal}
- >
- <i className="fa fa-edit" />
- </span>
- </Tooltip>
- {this.props.chart.sliceFormData && (
- <AlteredSliceTag
- className="altered"
- origFormData={this.props.chart.sliceFormData}
- currentFormData={formData}
- />
- )}
- </StyledButtons>
- )}
- </div>
- <div className="right-button-panel">
- {chartFinished && queryResponse && (
- <RowCountLabel
- rowcount={Number(queryResponse.rowcount) || 0}
- limit={Number(formData.row_limit) || 0}
- />
- )}
- {chartFinished && queryResponse && queryResponse.is_cached && (
- <CachedLabel
- onClick={this.postChartFormData.bind(this)}
- cachedTimestamp={queryResponse.cached_dttm}
- />
- )}
- <Timer
- startTime={chartUpdateStartTime}
- endTime={chartUpdateEndTime}
- isRunning={chartStatus === 'loading'}
- status={CHART_STATUS_MAP[chartStatus]}
+ <i className="fa fa-edit" />
+ </span>
+ </Tooltip>
+ {chart.sliceFormData && (
+ <AlteredSliceTag
+ className="altered"
+ origFormData={chart.sliceFormData}
+ currentFormData={formData}
+ />
+ )}
+ </StyledButtons>
+ )}
+ </div>
+ <div className="right-button-panel">
+ {chartFinished && queryResponse && (
+ <RowCountLabel
+ rowcount={Number(queryResponse.rowcount) || 0}
+ limit={Number(formData.row_limit) || 0}
/>
- {this.canAddReports() && this.renderReportModal()}
- <ReportModal
- show={this.state.showingReportModal}
- onHide={this.hideReportModal}
- props={{
- userId: this.props.user.userId,
- userEmail: this.props.user.email,
- chart: this.props.chart,
- creationMethod: 'charts',
- }}
+ )}
+ {chartFinished && queryResponse && queryResponse.is_cached && (
Review comment:
```suggestion
{chartFinished && queryResponse?.is_cached && (
```
This can be cleaned with [optional chaining](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining).
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
Review comment:
```suggestion
const hideReportModal = () => setShowingReportModal(false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87e6eee) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **increase** coverage by `0.00%`.
> The diff coverage is `56.41%`.
> :exclamation: Current head 87e6eee differs from pull request most recent head 2873e17. Consider uploading reports for the commit 2873e17 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 1569 1569
Lines 61687 61686 -1
Branches 6241 6241
=======================================
+ Hits 40927 40928 +1
+ Misses 19162 19160 -2
Partials 1598 1598
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.92% <56.41%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `48.61% <56.41%> (+2.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...2873e17](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/225015fd5a94c1a92cc9b110e3e3db5cd532d47b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (225015f) will **decrease** coverage by `0.04%`.
> The diff coverage is `64.70%`.
> :exclamation: Current head 7cf7dc1 differs from pull request most recent head d8a941d. Consider uploading reports for the commit d8a941d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.28% 66.24% -0.05%
==========================================
Files 1605 1603 -2
Lines 62863 62560 -303
Branches 6341 6322 -19
==========================================
- Hits 41666 41440 -226
+ Misses 19545 19470 -75
+ Partials 1652 1650 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <64.70%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `72.00% <ø> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.76% <64.70%> (+0.08%)` | :arrow_up: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `81.42% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `78.33% <0.00%> (-3.34%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `92.25% <0.00%> (-2.01%)` | :arrow_down: |
| [superset/explore/form\_data/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhwbG9yZS9mb3JtX2RhdGEvYXBpLnB5) | `93.75% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/dashboards/filter\_sets/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc2V0cy9hcGkucHk=) | `97.14% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/key\_value/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2FwaS5weQ==) | `79.78% <0.00%> (-1.74%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `84.87% <0.00%> (-1.46%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [225015f...d8a941d](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] QueenSuccessEbuka commented on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
QueenSuccessEbuka commented on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1011150451
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (482bfa7) into [master](https://codecov.io/gh/apache/superset/commit/2dfcbdb08c963c1755d98d47285ed38d0642aeac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dfcbdb) will **increase** coverage by `0.00%`.
> The diff coverage is `55.88%`.
> :exclamation: Current head 482bfa7 differs from pull request most recent head 7cf7dc1. Consider uploading reports for the commit 7cf7dc1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
=======================================
Coverage 66.05% 66.06%
=======================================
Files 1591 1591
Lines 62423 62415 -8
Branches 6287 6286 -1
=======================================
- Hits 41233 41232 -1
+ Misses 19568 19562 -6
+ Partials 1622 1621 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <55.88%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `14.66% <ø> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.15% <55.88%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `74.28% <0.00%> (+4.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dfcbdb...7cf7dc1](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/31d363716de09d9f21d649c83327dc2b67e34267?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (31d3637) will **decrease** coverage by `0.05%`.
> The diff coverage is `64.70%`.
> :exclamation: Current head 7cf7dc1 differs from pull request most recent head f9719c0. Consider uploading reports for the commit f9719c0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.29% 66.24% -0.06%
==========================================
Files 1603 1603
Lines 62768 62560 -208
Branches 6326 6322 -4
==========================================
- Hits 41613 41440 -173
+ Misses 19503 19470 -33
+ Partials 1652 1650 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <64.70%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `72.00% <ø> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.76% <64.70%> (+0.08%)` | :arrow_up: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `81.42% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `78.33% <0.00%> (-3.34%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `92.25% <0.00%> (-2.01%)` | :arrow_down: |
| [superset/explore/form\_data/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhwbG9yZS9mb3JtX2RhdGEvYXBpLnB5) | `93.75% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/dashboards/filter\_sets/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc2V0cy9hcGkucHk=) | `97.14% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/key\_value/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2FwaS5weQ==) | `79.78% <0.00%> (-1.74%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `84.87% <0.00%> (-1.46%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [31d3637...f9719c0](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2873e17) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.02%`.
> The diff coverage is `56.41%`.
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.32% -0.03%
==========================================
Files 1569 1569
Lines 61687 61732 +45
Branches 6241 6273 +32
==========================================
+ Hits 40927 40941 +14
- Misses 19162 19170 +8
- Partials 1598 1621 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.89% <56.41%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `48.61% <56.41%> (+2.03%)` | :arrow_up: |
| [...ugins/plugin-chart-echarts/src/Timeseries/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9pbmRleC50cw==) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Step/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9TdGVwL2luZGV4LnRz) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Area/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2luZGV4LnRz) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...-chart-echarts/src/Timeseries/Regular/Bar/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9pbmRleC50cw==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Regular/Line/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0xpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/Scatter/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1NjYXR0ZXIvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...echarts/src/Timeseries/Regular/SmoothLine/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1Ntb290aExpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...2873e17](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3762845) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head 3762845 differs from pull request most recent head 87e6eee. Consider uploading reports for the commit 87e6eee to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.30% -0.04%
==========================================
Files 1569 1569
Lines 61687 61625 -62
Branches 6241 6232 -9
==========================================
- Hits 40927 40863 -64
Misses 19162 19162
- Partials 1598 1600 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <57.14%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <57.14%> (+3.42%)` | :arrow_up: |
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `42.24% <0.00%> (-10.26%)` | :arrow_down: |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `53.75% <0.00%> (-7.23%)` | :arrow_down: |
| [...tend/src/components/Datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlTW9kYWwudHN4) | `70.00% <0.00%> (-0.74%)` | :arrow_down: |
| [superset/reports/commands/create.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `88.52% <0.00%> (-0.67%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `71.51% <0.00%> (-0.51%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `91.28% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `87.14% <0.00%> (-0.19%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `94.28% <0.00%> (-0.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.74% <0.00%> (-0.05%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...87e6eee](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceba18e) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.04%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head ceba18e differs from pull request most recent head 2b02e5d. Consider uploading reports for the commit 2b02e5d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.29% -0.05%
==========================================
Files 1569 1572 +3
Lines 61687 61784 +97
Branches 6241 6285 +44
==========================================
+ Hits 40927 40961 +34
- Misses 19162 19202 +40
- Partials 1598 1621 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <57.14%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.96% <57.14%> (+0.39%)` | :arrow_up: |
| [...ugins/plugin-chart-echarts/src/Timeseries/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9pbmRleC50cw==) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Step/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9TdGVwL2luZGV4LnRz) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../plugin-chart-echarts/src/Timeseries/Area/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2luZGV4LnRz) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...-chart-echarts/src/Timeseries/Regular/Bar/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9pbmRleC50cw==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Regular/Line/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0xpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/Scatter/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1NjYXR0ZXIvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...echarts/src/Timeseries/Regular/SmoothLine/index.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1Ntb290aExpbmUvaW5kZXgudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| [...rt-echarts/src/Timeseries/Regular/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...2b02e5d](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceba18e) into [master](https://codecov.io/gh/apache/superset/commit/2dfcbdb08c963c1755d98d47285ed38d0642aeac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dfcbdb) will **increase** coverage by `0.24%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head ceba18e differs from pull request most recent head e4aa9d4. Consider uploading reports for the commit e4aa9d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
+ Coverage 66.05% 66.29% +0.24%
==========================================
Files 1591 1572 -19
Lines 62423 61784 -639
Branches 6287 6285 -2
==========================================
- Hits 41233 40961 -272
+ Misses 19568 19202 -366
+ Partials 1622 1621 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <57.14%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.96% <57.14%> (+0.39%)` | :arrow_up: |
| [superset/common/request\_contexed\_based.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3JlcXVlc3RfY29udGV4ZWRfYmFzZWQucHk=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `63.85% <0.00%> (-6.69%)` | :arrow_down: |
| [superset/dashboards/filter\_state/commands/get.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvZ2V0LnB5) | `91.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...uperset/dashboards/filter\_state/commands/create.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvY3JlYXRlLnB5) | `92.85% <0.00%> (-1.27%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `29.72% <0.00%> (-0.94%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `86.59% <0.00%> (-0.77%)` | :arrow_down: |
| [...uperset/dashboards/filter\_state/commands/update.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvdXBkYXRlLnB5) | `95.00% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <0.00%> (-0.65%)` | :arrow_down: |
| [...uperset/dashboards/filter\_state/commands/delete.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvY29tbWFuZHMvZGVsZXRlLnB5) | `94.44% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [79 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dfcbdb...e4aa9d4](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r780500662
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
- renderReportModal() {
- const attachedReportExists = !!Object.keys(this.props.reports).length;
+ const renderReportModal = () => {
+ const attachedReportExists = !!Object.keys(reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
- showReportModal={this.showReportModal}
- hideReportModal={this.hideReportModal}
- toggleActive={this.props.toggleActive}
- deleteActiveReport={this.props.deleteActiveReport}
+ showReportModal={showReportModal}
Review comment:
could you test something for me. Instead of having a `showReportModal` function would it look the same if we just invoke the function inside? Meaning
`showReportModal={setShowingReportModal(true)}`
and the same for hide report modal. Would it work the same? If so, let's get rid of the extra functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] DavidWoolner commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
DavidWoolner commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r781490176
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,138 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ const { userId } = user;
Review comment:
thank you! I've removed the destructuring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (482bfa7) into [master](https://codecov.io/gh/apache/superset/commit/2dfcbdb08c963c1755d98d47285ed38d0642aeac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dfcbdb) will **increase** coverage by `0.00%`.
> The diff coverage is `55.88%`.
> :exclamation: Current head 482bfa7 differs from pull request most recent head e4aa9d4. Consider uploading reports for the commit e4aa9d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
=======================================
Coverage 66.05% 66.06%
=======================================
Files 1591 1591
Lines 62423 62415 -8
Branches 6287 6286 -1
=======================================
- Hits 41233 41232 -1
+ Misses 19568 19562 -6
+ Partials 1622 1621 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <55.88%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `14.66% <ø> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.15% <55.88%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `74.28% <0.00%> (+4.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dfcbdb...e4aa9d4](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cf7dc1) into [master](https://codecov.io/gh/apache/superset/commit/225015fd5a94c1a92cc9b110e3e3db5cd532d47b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (225015f) will **decrease** coverage by `0.04%`.
> The diff coverage is `64.70%`.
> :exclamation: Current head 7cf7dc1 differs from pull request most recent head d8a941d. Consider uploading reports for the commit d8a941d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.28% 66.24% -0.05%
==========================================
Files 1605 1603 -2
Lines 62863 62560 -303
Branches 6341 6322 -19
==========================================
- Hits 41666 41440 -226
+ Misses 19545 19470 -75
+ Partials 1652 1650 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <64.70%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `72.00% <ø> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.76% <64.70%> (+0.08%)` | :arrow_up: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `81.42% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `78.33% <0.00%> (-3.34%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `92.25% <0.00%> (-2.01%)` | :arrow_down: |
| [superset/explore/form\_data/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhwbG9yZS9mb3JtX2RhdGEvYXBpLnB5) | `93.75% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/dashboards/filter\_sets/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc2V0cy9hcGkucHk=) | `97.14% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/key\_value/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2FwaS5weQ==) | `79.78% <0.00%> (-1.74%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `84.87% <0.00%> (-1.46%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [225015f...d8a941d](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r791344323
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
Review comment:
This function can be cleaned to one line like this:
`const getSliceName = () => sliceName || t('%s - untitled', tableName);`
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
Review comment:
```suggestion
const closePropertiesModal = () => setIsPropertiesModalOpen(false);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
Review comment:
```suggestion
const openPropertiesModal = () => setIsPropertiesModalOpen(true);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,142 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ if (canAddReports()) {
+ fetchUISpecificReport(user.userId, 'chart_id', 'charts', chart.id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, [
+ canAddReports,
+ fetchUISpecificReport,
+ user.userId,
+ chart.id,
+ dashboardId,
+ fetchChartDashboardData,
+ ]);
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ const {
+ chartStatus,
+ chartUpdateEndTime,
+ chartUpdateStartTime,
+ latestQueryFormData,
+ queriesResponse,
+ } = chart;
+ // TODO: when will get appropriate design for multi queries use all results and not first only
+ const queryResponse = queriesResponse?.[0];
+ const chartFinished = ['failed', 'rendered', 'success'].includes(
+ chart.chartStatus,
+ );
+ return (
+ <StyledHeader id="slice-header" className="panel-title-large">
+ <div className="title-panel">
+ {slice?.certified_by && (
+ <>
+ <CertifiedBadge
+ certifiedBy={slice.certified_by}
+ details={slice.certification_details}
+ />{' '}
+ </>
+ )}
+ <EditableTitle
+ title={getSliceName()}
Review comment:
```suggestion
title={getSliceName}
```
This doesn't need to be instantiated.
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
Review comment:
```suggestion
const showReportModal = () => setShowingReportModal(true);
```
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -248,134 +226,142 @@ export class ExploreChartHeader extends React.PureComponent {
),
);
return permissions[0].length > 0;
- }
+ };
- render() {
- const { user, form_data: formData, slice } = this.props;
- const {
- chartStatus,
- chartUpdateEndTime,
- chartUpdateStartTime,
- latestQueryFormData,
- queriesResponse,
- } = this.props.chart;
- // TODO: when will get appropriate design for multi queries use all results and not first only
- const queryResponse = queriesResponse?.[0];
- const chartFinished = ['failed', 'rendered', 'success'].includes(
- this.props.chart.chartStatus,
- );
- return (
- <StyledHeader id="slice-header" className="panel-title-large">
- <div className="title-panel">
- {slice?.certified_by && (
- <>
- <CertifiedBadge
- certifiedBy={slice.certified_by}
- details={slice.certification_details}
- />{' '}
- </>
- )}
- <EditableTitle
- title={this.getSliceName()}
- canEdit={
- !this.props.slice ||
- this.props.can_overwrite ||
- (this.props.slice?.owners || []).includes(
- this.props?.user?.userId,
- )
- }
- onSaveTitle={this.props.actions.updateChartTitle}
- />
+ useEffect(() => {
+ if (canAddReports()) {
+ fetchUISpecificReport(user.userId, 'chart_id', 'charts', chart.id);
+ }
+ if (dashboardId) {
+ fetchChartDashboardData();
+ }
+ }, [
+ canAddReports,
+ fetchUISpecificReport,
+ user.userId,
+ chart.id,
+ dashboardId,
+ fetchChartDashboardData,
+ ]);
- {this.props.slice && (
- <StyledButtons>
- {user.userId && (
- <FaveStar
- itemId={this.props.slice.slice_id}
- fetchFaveStar={this.props.actions.fetchFaveStar}
- saveFaveStar={this.props.actions.saveFaveStar}
- isStarred={this.props.isStarred}
- showTooltip
- />
- )}
- {this.state.isPropertiesModalOpen && (
- <PropertiesModal
- show={this.state.isPropertiesModalOpen}
- onHide={this.closePropertiesModal}
- onSave={this.props.sliceUpdated}
- slice={this.props.slice}
- />
- )}
- <Tooltip
- id="edit-desc-tooltip"
- title={t('Edit chart properties')}
+ const {
+ chartStatus,
+ chartUpdateEndTime,
+ chartUpdateStartTime,
+ latestQueryFormData,
+ queriesResponse,
+ } = chart;
+ // TODO: when will get appropriate design for multi queries use all results and not first only
+ const queryResponse = queriesResponse?.[0];
+ const chartFinished = ['failed', 'rendered', 'success'].includes(
+ chart.chartStatus,
+ );
+ return (
+ <StyledHeader id="slice-header" className="panel-title-large">
+ <div className="title-panel">
+ {slice?.certified_by && (
+ <>
+ <CertifiedBadge
+ certifiedBy={slice.certified_by}
+ details={slice.certification_details}
+ />{' '}
+ </>
+ )}
+ <EditableTitle
+ title={getSliceName()}
+ canEdit={
+ !slice ||
+ canOverwrite ||
+ (slice?.owners || []).includes(user?.userId)
+ }
+ onSaveTitle={actions.updateChartTitle}
+ />
+
+ {slice && (
+ <StyledButtons>
+ {user.userId && (
+ <FaveStar
+ itemId={slice.slice_id}
+ fetchFaveStar={actions.fetchFaveStar}
+ saveFaveStar={actions.saveFaveStar}
+ isStarred={isStarred}
+ showTooltip
+ />
+ )}
+ {isPropertiesModalOpen && (
+ <PropertiesModal
+ show={isPropertiesModalOpen}
+ onHide={closePropertiesModal}
+ onSave={sliceUpdated}
+ slice={slice}
+ />
+ )}
+ <Tooltip id="edit-desc-tooltip" title={t('Edit chart properties')}>
+ <span
+ aria-label={t('Edit chart properties')}
+ role="button"
+ tabIndex={0}
+ className="edit-desc-icon"
+ onClick={openPropertiesModal}
>
- <span
- aria-label={t('Edit chart properties')}
- role="button"
- tabIndex={0}
- className="edit-desc-icon"
- onClick={this.openPropertiesModal}
- >
- <i className="fa fa-edit" />
- </span>
- </Tooltip>
- {this.props.chart.sliceFormData && (
- <AlteredSliceTag
- className="altered"
- origFormData={this.props.chart.sliceFormData}
- currentFormData={formData}
- />
- )}
- </StyledButtons>
- )}
- </div>
- <div className="right-button-panel">
- {chartFinished && queryResponse && (
- <RowCountLabel
- rowcount={Number(queryResponse.rowcount) || 0}
- limit={Number(formData.row_limit) || 0}
- />
- )}
- {chartFinished && queryResponse && queryResponse.is_cached && (
- <CachedLabel
- onClick={this.postChartFormData.bind(this)}
- cachedTimestamp={queryResponse.cached_dttm}
- />
- )}
- <Timer
- startTime={chartUpdateStartTime}
- endTime={chartUpdateEndTime}
- isRunning={chartStatus === 'loading'}
- status={CHART_STATUS_MAP[chartStatus]}
+ <i className="fa fa-edit" />
+ </span>
+ </Tooltip>
+ {chart.sliceFormData && (
+ <AlteredSliceTag
+ className="altered"
+ origFormData={chart.sliceFormData}
+ currentFormData={formData}
+ />
+ )}
+ </StyledButtons>
+ )}
+ </div>
+ <div className="right-button-panel">
+ {chartFinished && queryResponse && (
+ <RowCountLabel
+ rowcount={Number(queryResponse.rowcount) || 0}
+ limit={Number(formData.row_limit) || 0}
/>
- {this.canAddReports() && this.renderReportModal()}
- <ReportModal
- show={this.state.showingReportModal}
- onHide={this.hideReportModal}
- props={{
- userId: this.props.user.userId,
- userEmail: this.props.user.email,
- chart: this.props.chart,
- creationMethod: 'charts',
- }}
+ )}
+ {chartFinished && queryResponse && queryResponse.is_cached && (
Review comment:
```suggestion
{chartFinished && queryResponse?.is_cached && (
```
This can be cleaned with [optional chaining](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining).
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
Review comment:
```suggestion
const hideReportModal = () => setShowingReportModal(false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3762845) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head 3762845 differs from pull request most recent head 422e9a3. Consider uploading reports for the commit 422e9a3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
==========================================
- Coverage 66.34% 66.30% -0.04%
==========================================
Files 1569 1569
Lines 61687 61625 -62
Branches 6241 6232 -9
==========================================
- Hits 40927 40863 -64
Misses 19162 19162
- Partials 1598 1600 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.87% <57.14%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <57.14%> (+3.42%)` | :arrow_up: |
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `42.24% <0.00%> (-10.26%)` | :arrow_down: |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `53.75% <0.00%> (-7.23%)` | :arrow_down: |
| [...tend/src/components/Datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlTW9kYWwudHN4) | `70.00% <0.00%> (-0.74%)` | :arrow_down: |
| [superset/reports/commands/create.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `88.52% <0.00%> (-0.67%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `71.51% <0.00%> (-0.51%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `91.28% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `87.14% <0.00%> (-0.19%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `94.28% <0.00%> (-0.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.74% <0.00%> (-0.05%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...422e9a3](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17970:
URL: https://github.com/apache/superset/pull/17970#issuecomment-1010169388
# [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17970](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87e6eee) into [master](https://codecov.io/gh/apache/superset/commit/7728db741049e16cb81d87a50853436f22380ed9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7728db7) will **increase** coverage by `0.00%`.
> The diff coverage is `56.41%`.
[](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17970 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 1569 1569
Lines 61687 61686 -1
Branches 6241 6241
=======================================
+ Hits 40927 40928 +1
+ Misses 19162 19160 -2
Partials 1598 1598
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.92% <56.41%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `48.61% <56.41%> (+2.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7728db7...87e6eee](https://codecov.io/gh/apache/superset/pull/17970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] DavidWoolner commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
DavidWoolner commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r780518934
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
- renderReportModal() {
- const attachedReportExists = !!Object.keys(this.props.reports).length;
+ const renderReportModal = () => {
+ const attachedReportExists = !!Object.keys(reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
- showReportModal={this.showReportModal}
- hideReportModal={this.hideReportModal}
- toggleActive={this.props.toggleActive}
- deleteActiveReport={this.props.deleteActiveReport}
+ showReportModal={showReportModal}
Review comment:
Yes! I've made the change as requested and it seems to work fine. Should I do the same for `openPropertiesModal` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #17970: refactor(explorechartheader): convert class to functional component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #17970:
URL: https://github.com/apache/superset/pull/17970#discussion_r781350510
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
##########
@@ -169,53 +159,42 @@ export class ExploreChartHeader extends React.PureComponent {
}
})
.catch(() => {});
- }
+ };
- getSliceName() {
- const { sliceName, table_name: tableName } = this.props;
+ const getSliceName = () => {
const title = sliceName || t('%s - untitled', tableName);
return title;
- }
+ };
- postChartFormData() {
- this.props.actions.postChartFormData(
- this.props.form_data,
- true,
- this.props.timeout,
- this.props.chart.id,
- this.props.ownState,
- );
- }
+ const postChartFormData = () => {
+ actions.postChartFormData(formData, true, timeout, chart.id, ownState);
+ };
- openPropertiesModal() {
- this.setState({
- isPropertiesModalOpen: true,
- });
- }
+ const openPropertiesModal = () => {
+ setIsPropertiesModalOpen(true);
+ };
- closePropertiesModal() {
- this.setState({
- isPropertiesModalOpen: false,
- });
- }
+ const closePropertiesModal = () => {
+ setIsPropertiesModalOpen(false);
+ };
- showReportModal() {
- this.setState({ showingReportModal: true });
- }
+ const showReportModal = () => {
+ setShowingReportModal(true);
+ };
- hideReportModal() {
- this.setState({ showingReportModal: false });
- }
+ const hideReportModal = () => {
+ setShowingReportModal(false);
+ };
- renderReportModal() {
- const attachedReportExists = !!Object.keys(this.props.reports).length;
+ const renderReportModal = () => {
+ const attachedReportExists = !!Object.keys(reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
- showReportModal={this.showReportModal}
- hideReportModal={this.hideReportModal}
- toggleActive={this.props.toggleActive}
- deleteActiveReport={this.props.deleteActiveReport}
+ showReportModal={showReportModal}
Review comment:
yes! Sorry meant to answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org