You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2007/05/16 23:06:16 UTC
[jira] Created: (DIRSERVER-934) Controls are not used into Bind
request
Controls are not used into Bind request
---------------------------------------
Key: DIRSERVER-934
URL: https://issues.apache.org/jira/browse/DIRSERVER-934
Project: Directory ApacheDS
Issue Type: Bug
Affects Versions: 1.0.1, 1.5.0
Reporter: Emmanuel Lecharny
We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520944 ]
Emmanuel Lecharny commented on DIRSERVER-934:
---------------------------------------------
There is also another problem :
controls are not handled in all ExtendedOperations.
The main problem with controls is that they may be handled differently by each operations (the 'sort' control has no meaning for a add operation, but is really important for the search operation). If we implement the no-op control (https://opends.dev.java.net/public/standards/draft-zeilenga-ldap-noop.txt), it will have impacts on add, modify and delete operations.
It seems that the control handling will have to be reviexed in the next few months to be sure we handle it correctly.
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520819 ]
Emmanuel Lecharny commented on DIRSERVER-934:
---------------------------------------------
Yes, this is still the case. There is no code in BindHandler to handle the controls :(
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520958 ]
Emmanuel Lecharny commented on DIRSERVER-934:
---------------------------------------------
Partially solved the problem in commit :
http://svn.apache.org/viewvc?view=rev&rev=567410
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reassigned DIRSERVER-934:
-------------------------------------------
Assignee: Emmanuel Lecharny
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu closed DIRSERVER-934.
-----------------------------------
Resolution: Fixed
Fixed this issue in many ways:
o properly injecting request controls into operation contexts
o properly extracting response controls from operation contexts
o cleaned up control handling throughout all operations
o removed some ambiguities with control classes used in Message hierarchy
Here are the commits for the fix:
http://svn.apache.org/viewvc?view=rev&revision=569237
http://svn.apache.org/viewvc?view=rev&revision=569235
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu reassigned DIRSERVER-934:
---------------------------------------
Assignee: Alex Karasulu (was: Emmanuel Lecharny)
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520737 ]
Alex Karasulu commented on DIRSERVER-934:
-----------------------------------------
This still the case? Again thought this was addressed. Could you provide some more data?
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520941 ]
Emmanuel Lecharny commented on DIRSERVER-934:
---------------------------------------------
While looking at the code, I realized that there is a potential breakage in the way controls are handled : to transfer controls to the context, we are using a static EMPTY_CONTROLS array, which is not protected against concurrent access. During the Map -> Array transformation, there is a chance that the controls are totally losts if two requests are handled in parallel.
As a result, I have created an abstract class called LdapHandler, inherited by all the handler, containing a setControls( LdapContext, Message ) method, in charge to load the controls into the context, if any. We will create a real array from the Map without using a static member.
This method will be called in all handler, including Bind, except for AbandonRequest (I'm not sure we need to handle controls in AbandonRequest, but I may be wrong).
Thoughts ?
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-934) Controls are not used into Bind
request
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-934:
----------------------------------------
Fix Version/s: 1.5.1
To be fixed
> Controls are not used into Bind request
> ---------------------------------------
>
> Key: DIRSERVER-934
> URL: https://issues.apache.org/jira/browse/DIRSERVER-934
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.5.0
> Reporter: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We don't inject controls into the server if we have one withing a BindRequest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.