[GitHub] [flink] zentol commented on a change in pull request #17893: [FLINK-24987][Configuration] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for ExternalizedCheckpointRetention

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #17893:
URL: https://github.com/apache/flink/pull/17893#discussion_r757006554



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
##########
@@ -446,7 +447,7 @@ public void setTolerableCheckpointFailureNumber(int tolerableCheckpointFailureNu
      * @param cleanupMode Externalized checkpoint cleanup behaviour.
      */
     @PublicEvolving
-    public void enableExternalizedCheckpoints(ExternalizedCheckpointCleanup cleanupMode) {
+    public void setExternalizedCheckpointCleanup(ExternalizedCheckpointCleanup cleanupMode) {

Review comment:
       In fact it broke the python api :)
   
   `
   Nov 24 11:28:23 FAILED pyflink/datastream/tests/test_check_point_config.py::CheckpointConfigTests::test_get_set_externalized_checkpoints_cleanup`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org