You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2026/09/16 11:59:05 UTC

(superset) branch master updated: fix(ci): match migration conflicts on filename, not contents_url (#44318)

This is an automated email from the ASF dual-hosted git repository.

aminghadersohi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 23bc3de0ca3 fix(ci): match migration conflicts on filename, not contents_url (#44318)
23bc3de0ca3 is described below

commit 23bc3de0ca3224101aa9f5f1f5d4f147a1161be1
Author: Amin Ghadersohi <am...@gmail.com>
AuthorDate: Wed Sep 16 21:58:57 2026 +1000

    fix(ci): match migration conflicts on filename, not contents_url (#44318)
---
 .github/workflows/check-db-migration-confict.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/check-db-migration-confict.yml b/.github/workflows/check-db-migration-confict.yml
index 007f88fefc9..a31436f5b52 100644
--- a/.github/workflows/check-db-migration-confict.yml
+++ b/.github/workflows/check-db-migration-confict.yml
@@ -60,12 +60,14 @@ jobs:
                 pull_number: pull.number,
               });
               const files = await github.paginate(listFilesOpts);
+              // Match on `filename`, not `contents_url`: the API percent-encodes
+              // path separators in `contents_url` (`/contents/superset%2Fmigrations%2F...`),
+              // so a substring test for `/contents/superset/migrations` never matches.
               if (
-                files.some(x => x.contents_url.includes('/contents/superset/migrations'))
+                files.some(x => x.filename.startsWith('superset/migrations/'))
               ) {
                 console.log(`PR #${pull.number} "${pull.title}" also added db migration`)
                 await github.rest.issues.createComment({
-                  issue_number: context.issue.number,
                   owner: context.repo.owner,
                   repo: context.repo.repo,
                   issue_number: pull.number,