You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2025/01/14 14:42:46 UTC
[PR] Add support of managing the raft cluster via the client [kvrocks-controller]
git-hulk opened a new pull request, #258:
URL: https://github.com/apache/kvrocks-controller/pull/258
```bash
❯ _build/kvctl raft list peers
|---------|-----------------------|-----------|
| NODE ID | NODE ADDRESS | IS LEADER |
|---------|-----------------------|-----------|
| 1 | http://127.0.0.1:6001 | YES |
|---------|-----------------------|-----------|
❯ _build/kvctl raft add peer 2 http://127.0.0.1:6002
Add node '2' with address 'http://127.0.0.1:6002' successfully
❯ _build/kvctl -H "http://127.0.0.1:9380" raft remove peer 2
Remove node '2' successfully
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support of managing the raft cluster via the client [kvrocks-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #258:
URL: https://github.com/apache/kvrocks-controller/pull/258#issuecomment-2590130345
## [Codecov](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `106 lines` in your changes missing coverage. Please review.
> Project coverage is 46.11%. Comparing base [(`6c56470`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/6c564700d621ef30a182bad1bfeff0aa13db6ea7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1a87e70`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/1a87e70b35cfcf0727eae5ca47340c66daa6124f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 34 commits behind head on unstable.
| [Files with missing lines](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [cmd/client/command/raft.go](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?src=pr&el=tree&filepath=cmd%2Fclient%2Fcommand%2Fraft.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y21kL2NsaWVudC9jb21tYW5kL3JhZnQuZ28=) | 0.00% | [105 Missing :warning: ](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cmd/client/main.go](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?src=pr&el=tree&filepath=cmd%2Fclient%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y21kL2NsaWVudC9tYWluLmdv) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## unstable #258 +/- ##
============================================
+ Coverage 43.38% 46.11% +2.72%
============================================
Files 37 44 +7
Lines 2971 4038 +1067
============================================
+ Hits 1289 1862 +573
- Misses 1544 1982 +438
- Partials 138 194 +56
```
| [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.11% <0.00%> (+2.72%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kvrocks-controller/pull/258?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support of managing the raft cluster via the client [kvrocks-controller]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #258:
URL: https://github.com/apache/kvrocks-controller/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org