[jira] [Work logged] (HDFS-16244) Add the necessary write lock in Checkpointer#doCheckpoint()

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16244?focusedWorklogId=657055&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657055 ]

ASF GitHub Bot logged work on HDFS-16244:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Sep/21 08:33
            Start Date: 29/Sep/21 08:33
    Worklog Time Spent: 10m 
      Work Description: jianghuazhu opened a new pull request #3497:
URL: https://github.com/apache/hadoop/pull/3497


   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   In Checkpointer#doCheckpoint(), when you need to execute reloadFromImageFile(), you need to add the necessary write lock.
   
   ### How was this patch tested?
   Need to verify the correctness of Checkpointer#doCheckpoint().
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 657055)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add the necessary write lock in Checkpointer#doCheckpoint()
> -----------------------------------------------------------
>
>                 Key: HDFS-16244
>                 URL: https://issues.apache.org/jira/browse/HDFS-16244
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: JiangHua Zhu
>            Assignee: JiangHua Zhu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When BackupNode is enabled, Checkpointer#doCheckpoint() will start to work.
> When the image file needs to be reloaded, there is a call link, for example:
> FSImage#reloadFromImageFile()->FSNamesystem#clear()->FSDirectory#reset().
> In FSDirectory#reset(), the write lock needs to be acquired in advance, for example:
>    void reset() {
>      writeLock();
>      try {
>      ......
>      } finally {
>        writeUnlock();
>      }
>    }
> However, no write lock has been acquired before this.
> You will get an exception message at this time, for example:
> java.lang.AssertionError: Should hold namesystem write lock



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org