You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/22 16:08:26 UTC

[GitHub] [arrow] mindhash opened a new pull request #7014: Go: Minor change to make newBuilder public to aid upstream

mindhash opened a new pull request #7014:
URL: https://github.com/apache/arrow/pull/7014


   Hello team,
   This minor change makes newBuilder() public to reduce verbosity in upstream. 
   
   To give you example, I am working on a parquet read / write into Arrow Record batch where the parquet data types are mapped to Arrow data types.  
   My Repo: https://github.com/mindhash/arrow-parquet-go
   
   In such cases, it will be nice to have a builder API (newBuilder) be generic to accept a data type and return a respective array.
   
   I am looking at a similar situation for JSON reader. I think this change will make the builder API much easier for upstream as well as internal packages. 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on issue #7014: ARROW-8563: GO Minor change to make newBuilder public

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-618187424


   https://issues.apache.org/jira/browse/ARROW-8563


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on issue #7014: Go: Minor change to make newBuilder public to aid upstream

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-617881461


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm closed pull request #7014: ARROW-8563: [Go] Minor change to make newBuilder public

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7014:
URL: https://github.com/apache/arrow/pull/7014


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org