You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Roman Schmitz <ro...@gmail.com> on 2022/11/12 20:47:25 UTC

[DISCUSS] KIP-887 - Add ConfigProvider to make use of environment variables

Hi all,

as I had this discussion with several customers and also colleagues I'd
like to implement a ConfigProvider that makes use of env variables,

Please let me know if you have any comments, questions, or suggestions!

https://cwiki.apache.org/confluence/display/KAFKA/KIP-887%3A+Add+ConfigProvider+to+make+use+of+environment+variables

Thanks,
Roman

Re: [DISCUSS] KIP-887 - Add ConfigProvider to make use of environment variables

Posted by Roman Schmitz <ro...@gmail.com>.

Hi all,

following up on this KIP ! As there was some discussion as part of the
review of the PR (https://github.com/apache/kafka/pull/12992) I'd like to
inform you about the changes that were made:
- The Env-Var-Config provider has been implemented as originally discussed.
- A security feature was added: Whitelisting the envvars with a regex in a
property *env.var.pattern* to allow only specific variables to be used to
avoid sniffing of sensitive data / variables with defaults to whitelist
everything (*).
- General agreement was that this feature is nice to have but not mandatory
for this KIP/PR to be implemented. As it was already implemented while
still in discussion we agreed to keep it with a default (*).

Cheers,
Roman

Am Mi., 14. Dez. 2022 um 21:34 Uhr schrieb Roman Schmitz <
roman.schmitz@gmail.com>:

> Hi Chris, Kirk,
>
> thanks for the feedback! I have created PR 12992:
> https://github.com/apache/kafka/pull/12992
>
> If you have any suggestions concerning the implementation, please let me
> know!
>
> Cheers,
> Roman
>
>
> Am Mi., 14. Dez. 2022 um 00:35 Uhr schrieb Kirk True <ki...@kirktrue.pro>:
>
>> Hi Roman,
>>
>> Thanks for the KIP! Looks pretty straightforward.
>>
>> Would it be possible to submit a pull request for your implementation so
>> that it is linked via Jira?
>>
>> Thanks,
>> Kirk
>>
>> On Tue, Dec 13, 2022, at 2:21 PM, Chris Egerton wrote:
>> > Hi Roman,
>> >
>> > Thanks for the KIP, LGTM. I should note that I might have some review
>> > suggestions on the implementation but the design proposal (an
>> environment
>> > variable-driven config provider with the API described in the KIP) seems
>> > good to me.
>> >
>> > Cheers,
>> >
>> > Chris
>> >
>> > On Sat, Nov 12, 2022 at 3:47 PM Roman Schmitz <ro...@gmail.com>
>> > wrote:
>> >
>> > > Hi all,
>> > >
>> > > as I had this discussion with several customers and also colleagues
>> I'd
>> > > like to implement a ConfigProvider that makes use of env variables,
>> > >
>> > > Please let me know if you have any comments, questions, or
>> suggestions!
>> > >
>> > >
>> > >
>> https://eu01.z.antigena.com/l/9tPEJkvUHxfznLkUUC0v4AMuDOEOABJpxmFl_v7_oq~euI0ygOrYSABqdIviAc~Y~pzju9k0gGz9KSr0drMghyE8Ch-4wUK0T0adZL0IIiivmg-SuWhCpE6-jMNYTpQo36CliGmbnvM242uos7WNpoKXXSTMnGY5YbQVFSOuj7oChHQGfZJxChbAseSZnruHoVneorSVSe6k_xUO6DH77DUXZF7MuCNpYZg0ePalQEJpbnT~yxVLFHzL9h
>> > >
>> > > Thanks,
>> > > Roman
>> > >
>> >
>>
>

Re: [DISCUSS] KIP-887 - Add ConfigProvider to make use of environment variables

Posted by Roman Schmitz <ro...@gmail.com>.

Hi Chris, Kirk,

thanks for the feedback! I have created PR 12992:
https://github.com/apache/kafka/pull/12992

If you have any suggestions concerning the implementation, please let me
know!

Cheers,
Roman


Am Mi., 14. Dez. 2022 um 00:35 Uhr schrieb Kirk True <ki...@kirktrue.pro>:

> Hi Roman,
>
> Thanks for the KIP! Looks pretty straightforward.
>
> Would it be possible to submit a pull request for your implementation so
> that it is linked via Jira?
>
> Thanks,
> Kirk
>
> On Tue, Dec 13, 2022, at 2:21 PM, Chris Egerton wrote:
> > Hi Roman,
> >
> > Thanks for the KIP, LGTM. I should note that I might have some review
> > suggestions on the implementation but the design proposal (an environment
> > variable-driven config provider with the API described in the KIP) seems
> > good to me.
> >
> > Cheers,
> >
> > Chris
> >
> > On Sat, Nov 12, 2022 at 3:47 PM Roman Schmitz <ro...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > as I had this discussion with several customers and also colleagues I'd
> > > like to implement a ConfigProvider that makes use of env variables,
> > >
> > > Please let me know if you have any comments, questions, or suggestions!
> > >
> > >
> > >
> https://eu01.z.antigena.com/l/9tPEJkvUHxfznLkUUC0v4AMuDOEOABJpxmFl_v7_oq~euI0ygOrYSABqdIviAc~Y~pzju9k0gGz9KSr0drMghyE8Ch-4wUK0T0adZL0IIiivmg-SuWhCpE6-jMNYTpQo36CliGmbnvM242uos7WNpoKXXSTMnGY5YbQVFSOuj7oChHQGfZJxChbAseSZnruHoVneorSVSe6k_xUO6DH77DUXZF7MuCNpYZg0ePalQEJpbnT~yxVLFHzL9h
> > >
> > > Thanks,
> > > Roman
> > >
> >
>

Re: [DISCUSS] KIP-887 - Add ConfigProvider to make use of environment variables

Posted by Kirk True <ki...@kirktrue.pro>.

Hi Roman,

Thanks for the KIP! Looks pretty straightforward.

Would it be possible to submit a pull request for your implementation so that it is linked via Jira?

Thanks,
Kirk

On Tue, Dec 13, 2022, at 2:21 PM, Chris Egerton wrote:
> Hi Roman,
> 
> Thanks for the KIP, LGTM. I should note that I might have some review
> suggestions on the implementation but the design proposal (an environment
> variable-driven config provider with the API described in the KIP) seems
> good to me.
> 
> Cheers,
> 
> Chris
> 
> On Sat, Nov 12, 2022 at 3:47 PM Roman Schmitz <ro...@gmail.com>
> wrote:
> 
> > Hi all,
> >
> > as I had this discussion with several customers and also colleagues I'd
> > like to implement a ConfigProvider that makes use of env variables,
> >
> > Please let me know if you have any comments, questions, or suggestions!
> >
> >
> > https://eu01.z.antigena.com/l/9tPEJkvUHxfznLkUUC0v4AMuDOEOABJpxmFl_v7_oq~euI0ygOrYSABqdIviAc~Y~pzju9k0gGz9KSr0drMghyE8Ch-4wUK0T0adZL0IIiivmg-SuWhCpE6-jMNYTpQo36CliGmbnvM242uos7WNpoKXXSTMnGY5YbQVFSOuj7oChHQGfZJxChbAseSZnruHoVneorSVSe6k_xUO6DH77DUXZF7MuCNpYZg0ePalQEJpbnT~yxVLFHzL9h
> >
> > Thanks,
> > Roman
> >
>

Re: [DISCUSS] KIP-887 - Add ConfigProvider to make use of environment variables

Posted by Chris Egerton <ch...@aiven.io.INVALID>.

Hi Roman,

Thanks for the KIP, LGTM. I should note that I might have some review
suggestions on the implementation but the design proposal (an environment
variable-driven config provider with the API described in the KIP) seems
good to me.

Cheers,

Chris

On Sat, Nov 12, 2022 at 3:47 PM Roman Schmitz <ro...@gmail.com>
wrote:

> Hi all,
>
> as I had this discussion with several customers and also colleagues I'd
> like to implement a ConfigProvider that makes use of env variables,
>
> Please let me know if you have any comments, questions, or suggestions!
>
>
> https://eu01.z.antigena.com/l/9tPEJkvUHxfznLkUUC0v4AMuDOEOABJpxmFl_v7_oq~euI0ygOrYSABqdIviAc~Y~pzju9k0gGz9KSr0drMghyE8Ch-4wUK0T0adZL0IIiivmg-SuWhCpE6-jMNYTpQo36CliGmbnvM242uos7WNpoKXXSTMnGY5YbQVFSOuj7oChHQGfZJxChbAseSZnruHoVneorSVSe6k_xUO6DH77DUXZF7MuCNpYZg0ePalQEJpbnT~yxVLFHzL9h
>
> Thanks,
> Roman
>