[GitHub] [accumulo] ctubbsii commented on a change in pull request #1505: Optimize Tablet volume replacement

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1505: Optimize Tablet volume replacement
URL: https://github.com/apache/accumulo/pull/1505#discussion_r377803422
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
 ##########
 @@ -184,9 +184,8 @@ public static String switchRootTableVolume(String location) throws IOException {
    * for use it chooses a new tablet directory.
    */
   public static TabletFiles updateTabletVolumes(AccumuloServerContext context, ZooLock zooLock,
-      VolumeManager vm, KeyExtent extent, TabletFiles tabletFiles, boolean replicate)
-      throws IOException {
-    List<Pair<Path,Path>> replacements = ServerConstants.getVolumeReplacements();
 
 Review comment:
   Would it make more sense to keep the replacements assignment in this method, but short-circuit the method with a `if (replacements.isEmpty()) { return; }` line?
   
   It seems like this is a smaller change and would keep the logic all together that handles the updates, rather than place the special case of no replacements outside the method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services