You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Jonathan Alvarez-Gutierrez (Jira)" <ji...@apache.org> on 2019/11/06 21:01:00 UTC

[jira] [Updated] (BEAM-8573) @SplitRestriction's documented signature is incorrect

     [ https://issues.apache.org/jira/browse/BEAM-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Alvarez-Gutierrez updated BEAM-8573:
---------------------------------------------
    Description: 
The documented signature for DoFn.SplitRestriction is 
{code:java}
List<RestrictionT> splitRestriction( InputT element, RestrictionT restriction);{code}
This fails to compile with, for example:

{{@SplitRestriction split(long, OffsetRange): Must return void}}

It looks like the correct signature is:
{code:java}
void splitRestriction(InputT element, RestrictionT restriction,
    OutputReceiver<RestrictionT> restriction);{code}

  was:
The documented signature for DoFn.SplitRestriction is 
{code:java}
List<RestrictionT> splitRestriction( InputT element, RestrictionT restriction);{code}
This fails to compile with:

{{@SplitRestriction split(long, OffsetRange): Must return void}}

It looks like the correct signature is:
{code:java}
void splitRestriction(InputT element, RestrictionT restriction,
    OutputReceiver<RestrictionT> restriction);{code}


> @SplitRestriction's documented signature is incorrect
> -----------------------------------------------------
>
>                 Key: BEAM-8573
>                 URL: https://issues.apache.org/jira/browse/BEAM-8573
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.15.0
>            Reporter: Jonathan Alvarez-Gutierrez
>            Priority: Minor
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The documented signature for DoFn.SplitRestriction is 
> {code:java}
> List<RestrictionT> splitRestriction( InputT element, RestrictionT restriction);{code}
> This fails to compile with, for example:
> {{@SplitRestriction split(long, OffsetRange): Must return void}}
> It looks like the correct signature is:
> {code:java}
> void splitRestriction(InputT element, RestrictionT restriction,
>     OutputReceiver<RestrictionT> restriction);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)