You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by vrozov <gi...@git.apache.org> on 2015/09/28 22:31:41 UTC
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/92
APEX-164 - Changed log4j level to INFO from DEBUG
@243826 please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEX-164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 15ff9dd0d419edd030f57e58789b6d810d316761
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2015-09-28T20:19:56Z
APEX-164 #resolve changed log4j level to INFO from DEBUG
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/92#discussion_r40603482
--- Diff: apex-app-archetype/src/main/resources/archetype-resources/src/test/resources/log4j.properties ---
@@ -1,4 +1,4 @@
-log4j.rootLogger=DEBUG,CONSOLE
+log4j.rootLogger=INFO,CONSOLE
--- End diff --
I don't think we should make this change, especially not in the archetype, where users expect to see their own logging. It is sufficient when you limit the com.datatorrent output below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144555663
+1 for leaving it as DEBUG in the log4j.properties in the archetype. This is because in most cases, the archetype is used by someone who wants to try out developing his/her own first application. The user is very likely to try putting some logger.debug statements to see what's going on. The user can later switch to INFO or even WARN as desired, or even remove the log4j.properties from the APA altogether and use hadoop's default. We can add a couple sentences about this in our Application Package doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/92#discussion_r40606406
--- Diff: apex-app-archetype/src/main/resources/archetype-resources/src/test/resources/log4j.properties ---
@@ -1,4 +1,4 @@
-log4j.rootLogger=DEBUG,CONSOLE
+log4j.rootLogger=INFO,CONSOLE
--- End diff --
I would say blacklist what you don't want to see. Your line 21 already changes the com.datatorrent category to info, is that not sufficient? Why change the root logger? User of the archetype should initially see all output of user written code without extra steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-apex-core pull request: APEX-164 - Changed
log4j level t...
Posted by Chetan Narsude <ch...@datatorrent.com>.
I have a comment on David's comment. Moving this discussion to JIRA. Please
use that going forward.
On Wed, Sep 30, 2015 at 3:12 PM, vrozov <gi...@git.apache.org> wrote:
> Github user vrozov commented on the pull request:
>
>
> https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144559147
>
> Please don't use this pull request to discuss and vote on archetype
> log level. It is not part of the pull request anymore. See
> https://malhar.atlassian.net/browse/APEX-168.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144559147
Please don't use this pull request to discuss and vote on archetype log level. It is not part of the pull request anymore. See https://malhar.atlassian.net/browse/APEX-168.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144080004
I'll file a separate JIRA to discuss the archetype log4j.properties. Once there is an agreement on the level I'll create another pull request for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-apex-core pull request: APEX-164 - Changed
log4j level t...
Posted by Chetan Narsude <ch...@datatorrent.com>.
Let's give it some time to pickle. I have not heard any other response
welcoming or rejecting the idea.
On Mon, Sep 28, 2015 at 1:31 PM, vrozov <gi...@git.apache.org> wrote:
> GitHub user vrozov opened a pull request:
>
> https://github.com/apache/incubator-apex-core/pull/92
>
> APEX-164 - Changed log4j level to INFO from DEBUG
>
> @243826 please review
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/vrozov/incubator-apex-core APEX-164
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-apex-core/pull/92.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #92
>
> ----
> commit 15ff9dd0d419edd030f57e58789b6d810d316761
> Author: Vlad Rozov <v....@datatorrent.com>
> Date: 2015-09-28T20:19:56Z
>
> APEX-164 #resolve changed log4j level to INFO from DEBUG
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by 243826 <gi...@git.apache.org>.
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144575089
The discussion here applies to archetype log4j.properties and not to this pull request. I'll give it until Friday morning PST before pulling it in. Please give your comments today if you see a problem with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-apex-core pull request: APEX-164 - Changed
log4j level t...
Posted by Chetan Narsude <ch...@datatorrent.com>.
Let's give it some time to pickle. I have not heard any other response
welcoming or rejecting the idea.
On Mon, Sep 28, 2015 at 1:31 PM, vrozov <gi...@git.apache.org> wrote:
> GitHub user vrozov opened a pull request:
>
> https://github.com/apache/incubator-apex-core/pull/92
>
> APEX-164 - Changed log4j level to INFO from DEBUG
>
> @243826 please review
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/vrozov/incubator-apex-core APEX-164
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-apex-core/pull/92.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #92
>
> ----
> commit 15ff9dd0d419edd030f57e58789b6d810d316761
> Author: Vlad Rozov <v....@datatorrent.com>
> Date: 2015-09-28T20:19:56Z
>
> APEX-164 #resolve changed log4j level to INFO from DEBUG
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/92#discussion_r40608131
--- Diff: apex-app-archetype/src/main/resources/archetype-resources/src/test/resources/log4j.properties ---
@@ -1,4 +1,4 @@
-log4j.rootLogger=DEBUG,CONSOLE
+log4j.rootLogger=INFO,CONSOLE
--- End diff --
In this case should not it be log4j.rootLogger=ALL,CONSOLE? What if user decides to use trace or own custom level, not debug? Using DEBUG level sounds related to the level used by com.datatorrent loggers.
I'll make the change and exclude archetype resource from the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/92#discussion_r40605436
--- Diff: apex-app-archetype/src/main/resources/archetype-resources/src/test/resources/log4j.properties ---
@@ -1,4 +1,4 @@
-log4j.rootLogger=DEBUG,CONSOLE
+log4j.rootLogger=INFO,CONSOLE
--- End diff --
@tweise Thomas, can you please clarify. Do you mean that log level should not be changed from DEBUG to INFO at all or your comment applies only to archetype? Note that travis-ci builds already fail due to the limit, so we need to reduce amount of logging.
When users develop applications, do they want to see datatorrent and other 3rd party libraries debug level output? Should not that be limited to INFO level and they need to set DEBUG level for their own classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-164 - Changed log4j level t...
Posted by 243826 <gi...@git.apache.org>.
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144088138
@tweise, I am not sure which misunderstanding you are referring to. Regardless, I know your opinion. Thanks for sharing it. I am also looking for more experience and opinions on this. Let's make a decision when others have had chance to chime in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---