You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2023/01/11 13:36:39 UTC
[GitHub] [cassandra] adelapena opened a new pull request, #2082: CASSANDRA-17507 4.0: Fix legacy clustering serialization for paging with compact storage
adelapena opened a new pull request, #2082:
URL: https://github.com/apache/cassandra/pull/2082
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2082: CASSANDRA-17507 4.0: Fix legacy clustering serialization for paging with compact storage
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2082: CASSANDRA-17507 4.0: Fix legacy clustering serialization for paging with compact storage
URL: https://github.com/apache/cassandra/pull/2082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on a diff in pull request #2082: CASSANDRA-17507 4.0: Fix legacy clustering serialization for paging with compact storage
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on code in PR #2082:
URL: https://github.com/apache/cassandra/pull/2082#discussion_r1083664007
##########
NEWS.txt:
##########
@@ -51,6 +51,20 @@ restore snapshots created with the previous major version using the
'sstableloader' tool. You can upgrade the file format of your snapshots
using the provided 'sstableupgrade' tool.
+4.0.8
+=====
+
+New features
+------------
+
+Upgrading
+---------
+ - All previous versions of 4.x contained a mistake on the implementation of the old CQL native protocol v3. That
+ mistake produced issues when paging over tables with compact storage and a single clustering column during rolling
+ upgrades involving 3.x and 4.x nodes. The fix for that issue makes that it can now appear during rolling upgrades
+ from 4.0.0-4.0.7. If that your case, please use protocol v4 or higher in your driver. See CASSANDRA-17507 for
Review Comment:
- `The fix for that issue makes that it can now appear` -> `The fix for that issue makes ***it that*** it can now appear`?
- `if that _is/were_ your case`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org