You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/02 03:21:17 UTC
[GitHub] [spark] andygrove edited a comment on pull request #33140: [SPARK-35881][SQL] Add support for columnar execution of final query stage in AdaptiveSparkPlanExec
andygrove edited a comment on pull request #33140:
URL: https://github.com/apache/spark/pull/33140#issuecomment-872683064
> why does the final plan matter? are you going to change `df.collect` to leverage columnar execution as well?
We have no plans to change `df.collect`. The main issue is that `AdaptiveSparkPlanExec` isn't always the final plan. It can be contained inside other plans. One example is when writing the results of an adaptive plan to Parquet and we want to avoid unnecessary columnar-to-row followed by row-to-columnar when doing the columnar write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org