You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/12 03:36:56 UTC
[GitHub] [incubator-iotdb] Genius-pig commented on a change in pull request
#728: [IOTDB-414] fix the client display.
Genius-pig commented on a change in pull request #728: [IOTDB-414] fix the client display.
URL: https://github.com/apache/incubator-iotdb/pull/728#discussion_r365555435
##########
File path: client/src/main/java/org/apache/iotdb/client/AbstractClient.java
##########
@@ -478,15 +478,17 @@ private static void printBlockLine(boolean printTimestamp, int colCount,
} else {
blockLine.append("+");
}
- if (resultSetMetaData.getColumnName(2).equals(GROUPBY_DEVICE_COLUMN_NAME)) {
- maxValueLength = measurementColumnLength;
- } else {
- int tmp = Integer.MIN_VALUE;
- for (int i = 1; i <= colCount; i++) {
- int len = resultSetMetaData.getColumnLabel(i).length();
- tmp = Math.max(tmp, len);
+ if(printTimestamp) {
+ if (resultSetMetaData.getColumnName(2).equals(GROUPBY_DEVICE_COLUMN_NAME)) {
+ maxValueLength = measurementColumnLength;
+ } else {
+ int tmp = Integer.MIN_VALUE;
+ for (int i = 1; i <= colCount; i++) {
+ int len = resultSetMetaData.getColumnLabel(i).length();
+ tmp = Math.max(tmp, len);
+ }
+ maxValueLength = tmp;
}
- maxValueLength = tmp;
}
if(printTimestamp) {
Review comment:
Compression is a wrong syntax, the wrong syntax doesn't mean it gives an error message. Instead, It is identified as a normal property and doesn't influence anything. So if you use `create timeseries root.sg1.d2.s1 with datatype=INT64, encoding=RLE, compression=SNAPPY;`, root.sg1.d2.s1 will use UNCOMPRESSED.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services