You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2015/11/10 00:58:02 UTC
Review Request 40111: GEODE-494: remove failing test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40111/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
This test fails very intermittently but doesn't reflect any real-world
use case so I'm deleting it.
While debugging, found a logic error in PartitionManager but it seems
that the code path is never exercised (used only in tests).
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/partition/PartitionManager.java ceff534d03e34815c62501972e6a561093edfa3e
gemfire-core/src/test/java/com/gemstone/gemfire/cache/partition/PartitionManagerDUnitTest.java e061053141c9dcf0b7ddef30b69228fc33bf13fb
Diff: https://reviews.apache.org/r/40111/diff/
Testing
-------
Ran the following DUnits:
PartitionManagerDUnitTest
FixedPartitioningWithColocationAndPersistenceDUnitTest
FixedPartitioningDUnitTest
Thanks,
Jens Deppe
Re: Review Request 40111: GEODE-494: remove failing test
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40111/#review105775
-----------------------------------------------------------
I don't know about the PartitionManager change but the test changes are fine :)
- Bruce Schuchardt
On Nov. 9, 2015, 11:58 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40111/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 11:58 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This test fails very intermittently but doesn't reflect any real-world
> use case so I'm deleting it.
>
> While debugging, found a logic error in PartitionManager but it seems
> that the code path is never exercised (used only in tests).
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/partition/PartitionManager.java ceff534d03e34815c62501972e6a561093edfa3e
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/partition/PartitionManagerDUnitTest.java e061053141c9dcf0b7ddef30b69228fc33bf13fb
>
> Diff: https://reviews.apache.org/r/40111/diff/
>
>
> Testing
> -------
>
> Ran the following DUnits:
>
> PartitionManagerDUnitTest
> FixedPartitioningWithColocationAndPersistenceDUnitTest
> FixedPartitioningDUnitTest
>
>
> Thanks,
>
> Jens Deppe
>
>