You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2009/05/11 15:17:45 UTC
[jira] Created: (FELIX-1141) Provide feedback for operations
Provide feedback for operations
-------------------------------
Key: FELIX-1141
URL: https://issues.apache.org/jira/browse/FELIX-1141
Project: Felix
Issue Type: Improvement
Components: Web Console
Reporter: Felix Meschberger
Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev reassigned FELIX-1141:
---------------------------------------
Assignee: Felix Meschberger (was: Valentin Valchev)
I've committed the patch, but we still need German localization of the following property:
bundles.error.title=Error while executing bundle operation!
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Attachments: bundle-operation-error-feedback-2.patch, bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-1141:
------------------------------------
Attachment: bundle-operation-error-feedback.patch
I'm attaching a patch that adds feedback for failed bundle operations. As example, when Bundle.start() threw exception, the web console will pop-up error dialog, showing appropriate message in the title, and the whole stack trace in the dialog body.
The patch includes Bulgarian and English localization. German translation needed.
WDYT?
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1141) Provide feedback for operations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855299#action_12855299 ]
Felix Meschberger commented on FELIX-1141:
------------------------------------------
Patch looks good to me.
The hard problem probably is to convey back results of background tasks like bundle installation and update or package refresh.
Maybe we can add some sort of "back-channel" to the console where continous information is flowing back from the server to the console: Some sort of "permanent" connection displayed somewhere which is fed with events from a LogListener..... The hard thing probably is to keep this log open while switching web console pages but remove that when the web console is "left"
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1141) Provide feedback for operations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855315#action_12855315 ]
Felix Meschberger commented on FELIX-1141:
------------------------------------------
> My experience showed that using such "back-channel" is performance drawback.
Right, I did not see it from that angle, so lets drop the idea of a "back-channel"
> IMHO a better optimization is to update how these request are handled.
Yes. We can (and should) definitely optimize here, in fact, what could be the side effects:
* bundle stop -> only the stopped bundle's state changes to stop or exception is thrown
* bundle uninstall --> only the stopped bundle's state changes (actually it should be removed from the list) or exception is thrown
* bundle start -> this might have side effects on other bundles in they become resolved
So, for start/stop/uninstall we might in fact just return the new bundle state or the exception and just update the bundle entry on the client side (ignoring any side effects on other bundles due to bundle start)
This would reduce the data (either new state or exception) and the requests (a single request)
WDYT ?
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1141) Provide feedback for operations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-1141.
--------------------------------------
Resolution: Fixed
Committed the german translation in Rev. 933874.
So, I assume this can be resolved.
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: webconsole-3.0.2
>
> Attachments: bundle-operation-error-feedback-2.patch, bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855330#action_12855330 ]
Valentin Valchev commented on FELIX-1141:
-----------------------------------------
Yes, this is even better. Can you fix it that way? Or I will fix it next Monday.
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855313#action_12855313 ]
Valentin Valchev commented on FELIX-1141:
-----------------------------------------
My experience showed that using such "back-channel" is performance drawback. Yes, the applications is more responsible but scalability lowers. We used similar approach in some of ProSyst web applications but a "back-channel" means a "thread".
We mostly target embedded devices, so we typically limit active threads (pool) to 10. But if few web clients open a channel, this means, that 3 threads from the pool are non-stop occupied and never released.
Typically a browser opens 4 connection for web content and images. So it becomes really slowly, as HTTP wait more to obtain free threads.
----
IMHO a better optimization is to update how these request are handled. Now "start", "stop"... etc performs the action, and then renders the whole page again, which means:
- more data transferred
- more rendering operation
- less responsive UI
However, there are situations that no rendering is required. As example: start, stop throws exception. This means that the state will not be changed and no rendering required.
So we can simplify the code to handle only simple requests. Start, stop, etc action will not render Bundle JSON data. If the action succeeded, then another AJAX call will be posted to obtain the bundle data.
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1141) Provide feedback for operations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-1141:
----------------------------------------
Assignee: Valentin Valchev
I don't have the cycles today. It would be great, if you could work on it.
Thus assigning the issue to you. Thanks.
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Assignee: Valentin Valchev
> Attachments: bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-1141:
------------------------------------
Attachment: bundle-operation-error-feedback-2.patch
The attached bundle-operation-error-feedback-2.patch implements the proposed optimizations. (and still reports errors on action execution)
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
> Assignee: Valentin Valchev
> Attachments: bundle-operation-error-feedback-2.patch, bundle-operation-error-feedback.patch
>
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FELIX-1141) Provide feedback for operations
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837239#action_12837239 ]
Valentin Valchev commented on FELIX-1141:
-----------------------------------------
While implementing integration with JQuery UI I've added a simple dialog, that get's popped up when the AJAX request fails. And it also shows the user the error message, got as HTTP response.
This feature will work for all plugins automatically.
> Provide feedback for operations
> -------------------------------
>
> Key: FELIX-1141
> URL: https://issues.apache.org/jira/browse/FELIX-1141
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Felix Meschberger
>
> Currently the Web Console does provide almost no adequate feedback for operations like bundle installation, bundle start, configuration save, etc, etc. We need a way to provide such feedback to the client. This is a bit more tricky since many operations actually are executed in the background like actual bundle operations.
> I see this issue as a broadening of the feedback request in FELIX-1061
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.