You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2021/11/01 08:42:27 UTC
[royale-asjs] 01/02: Merge branch 'ChildResize' into develop
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d8a61862dfa751f762a1f699b5c1016729027409
Merge: fbf8fcb 0d781be
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Sun Oct 31 20:16:56 2021 +0200
Merge branch 'ChildResize' into develop
.../MXRoyale/src/main/resources/defaults.css | 2 -
.../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
.../MXRoyale/src/main/royale/mx/core/Container.as | 46 ++++++++++++++++++-
.../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
.../royale/spark/components/beads/GroupView.as | 21 +++++++--
.../components/beads/SkinnableContainerView.as | 14 ++++--
.../layouts/supportClasses/SparkLayoutBead.as | 52 +++++++++++++++++++++-
7 files changed, 207 insertions(+), 12 deletions(-)
RE: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Yishay Weiss <yi...@hotmail.com>.
Hi Andrew,
We expect containers to work as documented in Flex docs. That’s true for all emulation components so I do not think it warrants more documentation.
Thanks.
From: Andrew Wetmore<ma...@gmail.com>
Sent: Monday, November 1, 2021 2:52 PM
To: Apache Royale Development<ma...@royale.apache.org>
Subject: Re: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Should I add a description of what we now expect the behaviour to be,
somewhere in the docs on containers?
On Mon, Nov 1, 2021 at 6:59 AM Yishay Weiss <yi...@hotmail.com> wrote:
> Hi,
>
> I finally decided to merge ChildResize branch into develop which should
> improve layout in emulation layer for containers that include children
> added post-creation. Most of the changes were done by Alex over a year ago.
> I tested this branch on a project about a year ago and found that it solved
> many layout issues, though not all of them. Hopefully, when we resolve the
> conflicts with PR #1135 and merge, even more layout issues will be resolved.
>
> As I understand it, the basic idea is that container layouts listen on
> children’s ‘sizeChanged’ events and run layouts and measuremnts in
> response. In addition, if adding a child has resulted in the container
> changing its measured size then the container parent’s size is invalidated
> as well. This should allow size invalidation to bubble up if necessary,
> setting the stage for further measurements in the next layout cycle.
>
> There are additional commits that were made on this branch which should
> fix other issues unrelated to layout.
>
> Please let me know if this merge breaks anything, or if you object to them
> for other reasons. We can discuss what needs to be reverted in such a case.
>
> Thanks,
> Yishay
>
> From: yishayw@apache.org<ma...@apache.org>
> Sent: Monday, November 1, 2021 10:42 AM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
> commit d8a61862dfa751f762a1f699b5c1016729027409
> Merge: fbf8fcb 0d781be
> Author: Yishay Weiss <yi...@hotmail.com>
> AuthorDate: Sun Oct 31 20:16:56 2021 +0200
>
> Merge branch 'ChildResize' into develop
>
> .../MXRoyale/src/main/resources/defaults.css | 2 -
> .../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
> .../MXRoyale/src/main/royale/mx/core/Container.as | 46
> ++++++++++++++++++-
> .../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
> .../royale/spark/components/beads/GroupView.as | 21 +++++++--
> .../components/beads/SkinnableContainerView.as | 14 ++++--
> .../layouts/supportClasses/SparkLayoutBead.as | 52
> +++++++++++++++++++++-
> 7 files changed, 207 insertions(+), 12 deletions(-)
>
>
--
Andrew Wetmore
http://cottage14.blogspot.com/
Re: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Andrew Wetmore <co...@gmail.com>.
Should I add a description of what we now expect the behaviour to be,
somewhere in the docs on containers?
On Mon, Nov 1, 2021 at 6:59 AM Yishay Weiss <yi...@hotmail.com> wrote:
> Hi,
>
> I finally decided to merge ChildResize branch into develop which should
> improve layout in emulation layer for containers that include children
> added post-creation. Most of the changes were done by Alex over a year ago.
> I tested this branch on a project about a year ago and found that it solved
> many layout issues, though not all of them. Hopefully, when we resolve the
> conflicts with PR #1135 and merge, even more layout issues will be resolved.
>
> As I understand it, the basic idea is that container layouts listen on
> children’s ‘sizeChanged’ events and run layouts and measuremnts in
> response. In addition, if adding a child has resulted in the container
> changing its measured size then the container parent’s size is invalidated
> as well. This should allow size invalidation to bubble up if necessary,
> setting the stage for further measurements in the next layout cycle.
>
> There are additional commits that were made on this branch which should
> fix other issues unrelated to layout.
>
> Please let me know if this merge breaks anything, or if you object to them
> for other reasons. We can discuss what needs to be reverted in such a case.
>
> Thanks,
> Yishay
>
> From: yishayw@apache.org<ma...@apache.org>
> Sent: Monday, November 1, 2021 10:42 AM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
> commit d8a61862dfa751f762a1f699b5c1016729027409
> Merge: fbf8fcb 0d781be
> Author: Yishay Weiss <yi...@hotmail.com>
> AuthorDate: Sun Oct 31 20:16:56 2021 +0200
>
> Merge branch 'ChildResize' into develop
>
> .../MXRoyale/src/main/resources/defaults.css | 2 -
> .../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
> .../MXRoyale/src/main/royale/mx/core/Container.as | 46
> ++++++++++++++++++-
> .../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
> .../royale/spark/components/beads/GroupView.as | 21 +++++++--
> .../components/beads/SkinnableContainerView.as | 14 ++++--
> .../layouts/supportClasses/SparkLayoutBead.as | 52
> +++++++++++++++++++++-
> 7 files changed, 207 insertions(+), 12 deletions(-)
>
>
--
Andrew Wetmore
http://cottage14.blogspot.com/
RE: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Yishay Weiss <yi...@hotmail.com>.
Hi,
I finally decided to merge ChildResize branch into develop which should improve layout in emulation layer for containers that include children added post-creation. Most of the changes were done by Alex over a year ago. I tested this branch on a project about a year ago and found that it solved many layout issues, though not all of them. Hopefully, when we resolve the conflicts with PR #1135 and merge, even more layout issues will be resolved.
As I understand it, the basic idea is that container layouts listen on children’s ‘sizeChanged’ events and run layouts and measuremnts in response. In addition, if adding a child has resulted in the container changing its measured size then the container parent’s size is invalidated as well. This should allow size invalidation to bubble up if necessary, setting the stage for further measurements in the next layout cycle.
There are additional commits that were made on this branch which should fix other issues unrelated to layout.
Please let me know if this merge breaks anything, or if you object to them for other reasons. We can discuss what needs to be reverted in such a case.
Thanks,
Yishay
From: yishayw@apache.org<ma...@apache.org>
Sent: Monday, November 1, 2021 10:42 AM
To: commits@royale.apache.org<ma...@royale.apache.org>
Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d8a61862dfa751f762a1f699b5c1016729027409
Merge: fbf8fcb 0d781be
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Sun Oct 31 20:16:56 2021 +0200
Merge branch 'ChildResize' into develop
.../MXRoyale/src/main/resources/defaults.css | 2 -
.../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
.../MXRoyale/src/main/royale/mx/core/Container.as | 46 ++++++++++++++++++-
.../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
.../royale/spark/components/beads/GroupView.as | 21 +++++++--
.../components/beads/SkinnableContainerView.as | 14 ++++--
.../layouts/supportClasses/SparkLayoutBead.as | 52 +++++++++++++++++++++-
7 files changed, 207 insertions(+), 12 deletions(-)