[GitHub] eolivelli commented on a change in pull request #876: Issue 870: ScanAndCompareGarbageCollector: harden against LM bugs

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #876: Issue 870: ScanAndCompareGarbageCollector: harden against LM bugs
URL: https://github.com/apache/bookkeeper/pull/876#discussion_r157742448
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java
 ##########
 @@ -315,6 +319,228 @@ public void clean(long ledgerId) {
         assertEquals("Should have cleaned first ledger" + first, (long) first, (long) cleaned.get(0));
     }
 
+    /*
+     * in this scenario no ledger is created, so ledgeriterator's hasNext call would return false and next would be
+     * null. GarbageCollector.gc is expected to behave normally
+     */
+    @Test(timeout = 60000)
 
 Review comment:
   drop timeout

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services