You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2016/01/08 21:17:40 UTC

[jira] [Resolved] (THRIFT-3514) PHP 7 compatible version of binary protocol

     [ https://issues.apache.org/jira/browse/THRIFT-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-3514.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.9.4

Hi David & PHP people!

To be honest, I'm not the fan of redundant code, but it seems that you are willing to refactor this and other php coders like it as well, so I've committed this. Looking forward for other patches from the php community.

Thank you and all the PHP people for getting the open source code based internet really started ... LAMP! Where would we be today without?

all the best!
-roger

PS: could you close the PR on github?
here https://github.com/apache/thrift/pull/765
I forgot to do a git --amend to add the closes #765 line :-(



> PHP 7 compatible version of binary protocol
> -------------------------------------------
>
>                 Key: THRIFT-3514
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3514
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>            Reporter: David Soria Parra
>             Fix For: 0.9.4, 1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)