[GitHub] [airflow] bbovenzi opened a new pull request, #25729: Add origin request args when triggering a run

[GitBox <gi...@apache.org>]

bbovenzi opened a new pull request, #25729:
URL: https://github.com/apache/airflow/pull/25729

   Include the query parameters in the origin when manually triggering a dag run from the dag page. Prevents request errors when triggering a run from a task instance detail page and losing your place elsewhere the dag page.
   
   Fixes: https://github.com/apache/airflow/issues/24725
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #25729: Add origin request args when triggering a run

[GitBox <gi...@apache.org>]

bbovenzi merged PR #25729:
URL: https://github.com/apache/airflow/pull/25729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #25729: Add origin request args when triggering a run

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25729:
URL: https://github.com/apache/airflow/pull/25729#discussion_r947352610


##########
airflow/www/templates/airflow/dag.html:
##########
@@ -204,7 +204,12 @@ <h4 class="pull-right" style="user-select: none;-moz-user-select: auto;">
                   <input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
                   <input type="hidden" name="dag_id" value="{{ dag.dag_id }}">
                   <input type="hidden" name="unpause" value="True">
-                  <input type="hidden" name="origin" value="{{ url_for(request.endpoint, dag_id=dag.dag_id) }}">
+                  <!-- for task instance detail pages, dag_id is still a query param -->
+                  {% if request.args.get('dag_id') is not none %}

Review Comment:
   Not sure if this works…
   
   ```suggestion
                     {% if 'dag_id' in request.args %}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org