Re: svn commit: rev 1649 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

[cm...@collab.net]

cmpilato@tigris.org writes:

> Author: cmpilato
> Date: 2002-04-06 23:01 GMT
> New Revision: 1649
> 
> Modified:
>    trunk/subversion/clients/cmdline/util.c
>    trunk/subversion/libsvn_client/commit.c
> Log:
> Fix error handling when the $EDITOR is needed but unavailable.  Ah
> ... now that's *much* nicer.
> 
> * subversion/clients/cmdline/util.c
>   (svn_cl__edit_externally): Clean up the "no external editor" error message.
>   (svn_cl__get_log_message): Wrap "no external editor" errors with
> helpful hints about the -m and -F options.
> 
> * subversion/libsvn_client/commit.c
>   (svn_client_commit): Actually capture and propogate "no external
> editor" errors.


Okay, now if you have no editor in the environment variables, you
should see this:

   subversion/libsvn_client/commit.c:589
   svn_error: #21115 : <No external editor available>
     Commit failed (details follow):
   
   subversion/clients/cmdline/util.c:654
   svn_error: #21115 : <No external editor available>
     Could not use external editor to fetch log message; consider setting the
     $SVN_EDITOR environment variable or using the --message (-m) or --file 
     (-F) options.
   
   subversion/clients/cmdline/util.c:387
   svn_error: #21115 : <No external editor available>
     Could not find an external text editor in the usual environment 
     variables (searched SVN_EDITOR, EDITOR, VISUAL, in that order)

Is all better now?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org