[GitHub] [geode] sabbey37 commented on a change in pull request #6447: GEODE-9220: Switch Redis key tests to use JedisCluster

[GitBox <gi...@apache.org>]

sabbey37 commented on a change in pull request #6447:
URL: https://github.com/apache/geode/pull/6447#discussion_r628246428



##########
File path: geode-apis-compatible-with-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/key/DelNativeRedisAcceptanceTest.java
##########
@@ -16,17 +16,27 @@
 package org.apache.geode.redis.internal.executor.key;
 
 import org.junit.ClassRule;
+import org.junit.Test;
 
-import org.apache.geode.NativeRedisTestRule;
+import org.apache.geode.redis.NativeRedisClusterTestRule;
 
 public class DelNativeRedisAcceptanceTest extends AbstractDelIntegrationTest {
 
   @ClassRule
-  public static NativeRedisTestRule redis = new NativeRedisTestRule();
+  public static NativeRedisClusterTestRule redis = new NativeRedisClusterTestRule();
 
   @Override
   public int getPort() {
-    return redis.getPort();
+    return redis.getExposedPorts().get(0);
   }
 
+  @Override
+  public void flushAll() {
+    redis.flushAll();
+  }
+
+  @Test
+  public void doNothing() {
+    // nothing done
+  }

Review comment:
       What's this test for?

##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractScanIntegrationTest.java
##########
@@ -49,7 +49,7 @@ public void setUp() {
 
   @After
   public void tearDown() {
-    jedis.flushAll();
+    flushAll();
     jedis.close();
   }

Review comment:
       Did we decide not to switch this test to use a Jedis Cluster?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org