[GitHub] jmcarp commented on a change in pull request #4279: [AIRFLOW-3444] Explicitly set transfer operator description.

[GitBox <gi...@apache.org>]

jmcarp commented on a change in pull request #4279: [AIRFLOW-3444] Explicitly set transfer operator description.
URL: https://github.com/apache/incubator-airflow/pull/4279#discussion_r239233508
 
 

 ##########
 File path: airflow/contrib/operators/s3_to_gcs_transfer_operator.py
 ##########
 @@ -45,15 +45,14 @@ class S3ToGoogleCloudStorageTransferOperator(BaseOperator):
         For this to work, the service account making the request must have
         domain-wide delegation enabled.
     :type delegate_to: str
+    :param description: Optional transfer service job description
+    :type description: str
     :param object_conditions: Transfer service object conditions; see
         https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec
     :type object_conditions: dict
     :param transfer_options: Transfer service transfer options; see
         https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec
     :type transfer_options: dict
-    :param job_kwargs: Additional transfer job options; see
 
 Review comment:
   The `GCPTransferServiceHook` already sets the schedule so that the job runs right away and only once. Then the hook waits for the job to complete. If we want to allow custom schedules, I think we'd want to make waiting optional--it wouldn't make sense to schedule a job a day in the future, then wait for it to finish. I'll revise and add those options later today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services