You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/06/29 19:05:19 UTC
Review Request 12191: removed EnumerationImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
EnumerationImpl was not used and duplicates functionality
with org.apache.commons.collections.iterators.EnumerationIterator
Diffs
-----
utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3
Diff: https://reviews.apache.org/r/12191/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12191: removed EnumerationImpl
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On July 1, 2013, 3:07 p.m., Hugo Trippaers wrote:
> > Ship It!
>
> Hugo Trippaers wrote:
> master: 16b7509a234158b536155be9278cfee33b93a5c7
> 4.2: 00e99a08169b60b0449d67dfc891053cf4469bf7
This was the wrong patch, this is the removed CleanupDelegate patch. Can you submit the right patch for this review?
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22600
-----------------------------------------------------------
On June 29, 2013, 5:05 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 5:05 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3
>
> Diff: https://reviews.apache.org/r/12191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12191: removed EnumerationImpl
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On July 1, 2013, 3:07 p.m., Hugo Trippaers wrote:
> > Ship It!
master: 16b7509a234158b536155be9278cfee33b93a5c7
4.2: 00e99a08169b60b0449d67dfc891053cf4469bf7
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22600
-----------------------------------------------------------
On June 29, 2013, 5:05 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 5:05 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3
>
> Diff: https://reviews.apache.org/r/12191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12191: removed EnumerationImpl
Posted by Laszlo Hornyak <la...@gmail.com>.
> On July 1, 2013, 3:07 p.m., Hugo Trippaers wrote:
> > Ship It!
>
> Hugo Trippaers wrote:
> master: 16b7509a234158b536155be9278cfee33b93a5c7
> 4.2: 00e99a08169b60b0449d67dfc891053cf4469bf7
>
> Hugo Trippaers wrote:
> This was the wrong patch, this is the removed CleanupDelegate patch. Can you submit the right patch for this review?
oops, indeed! Sorry!
Sending again.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22600
-----------------------------------------------------------
On June 29, 2013, 5:05 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 5:05 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3
>
> Diff: https://reviews.apache.org/r/12191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12191: removed EnumerationImpl
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22600
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On June 29, 2013, 5:05 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 5:05 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3
>
> Diff: https://reviews.apache.org/r/12191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12191: removed EnumerationImpl
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22701
-----------------------------------------------------------
Ship it!
f15a6e4
- Prasanna Santhanam
On July 3, 2013, 4:33 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 4:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/EnumerationImpl.java 054b76d
>
> Diff: https://reviews.apache.org/r/12191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12191: removed EnumerationImpl
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/
-----------------------------------------------------------
(Updated July 3, 2013, 4:33 a.m.)
Review request for cloudstack.
Changes
-------
the right patch this time
Repository: cloudstack-git
Description
-------
EnumerationImpl was not used and duplicates functionality
with org.apache.commons.collections.iterators.EnumerationIterator
Diffs (updated)
-----
utils/src/com/cloud/utils/EnumerationImpl.java 054b76d
Diff: https://reviews.apache.org/r/12191/diff/
Testing
-------
Thanks,
Laszlo Hornyak