You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/23 01:33:45 UTC
Review Request 70044: Moved status update streams of operations on
agent's default resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
Bugs: MESOS-9597
https://issues.apache.org/jira/browse/MESOS-9597
Repository: mesos
Description
-------
This patch moves the operation status update streams for operations
affecting agent default resources from the root of the metadata
directory to the agent's metadata directory, i.e.,
`meta/operations/<operation_uuid>` to
`meta/slaves/<slave_id/operations/<operation_uuid>`.
Diffs
-----
src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70044/diff/1/
Testing
-------
Thanks,
Gastón Kleiman
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213235
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 26, 2019, 7:01 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 7:01 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id>/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/2/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213232
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69977, 69978, 70044]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 26, 2019, 7:01 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 7:01 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id>/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/2/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213231
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69977, 69978, 70044]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 26, 2019, 11:01 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 11:01 a.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id>/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/2/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/
-----------------------------------------------------------
(Updated Feb. 26, 2019, 11:01 a.m.)
Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
Changes
-------
Added comments.
Bugs: MESOS-9597
https://issues.apache.org/jira/browse/MESOS-9597
Repository: mesos
Description
-------
This patch moves the operation status update streams for operations
affecting agent default resources from the root of the metadata
directory to the agent's metadata directory, i.e.,
`meta/operations/<operation_uuid>` to
`meta/slaves/<slave_id/operations/<operation_uuid>`.
Diffs (updated)
-----
src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70044/diff/2/
Changes: https://reviews.apache.org/r/70044/diff/1-2/
Testing
-------
Tests still pass on GNU/Linux + quite some manual testing.
Thanks,
Gastón Kleiman
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
> On Feb. 26, 2019, 10:46 a.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 7452 (patched)
> > <https://reviews.apache.org/r/70044/diff/1/?file=2126445#file2126445line7461>
> >
> > What's the reason for moving this?
I had to change the method's signature in order to be able to be able to short-circuit the recovery process by returning `Nothing()` (and not doing anything) if there is no checkpointed state.
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213205
-----------------------------------------------------------
On Feb. 22, 2019, 5:34 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2019, 5:34 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/1/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213205
-----------------------------------------------------------
Note on commit message: s/<slave_id/<slave_id>/
src/slave/paths.hpp
Lines 365 (patched)
<https://reviews.apache.org/r/70044/#comment299075>
Could you add a header comment for this? I know it'll be pretty simple, but I hate to see new functions added to headers with no comments. I think brief explanations of what the functions do would be beneficial. Here and below.
src/slave/slave.cpp
Lines 7452 (patched)
<https://reviews.apache.org/r/70044/#comment299134>
What's the reason for moving this?
- Greg Mann
On Feb. 23, 2019, 1:34 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 1:34 a.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/1/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213119
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69977, 69978, 70044]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 23, 2019, 1:34 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 1:34 a.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/1/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/#review213107
-----------------------------------------------------------
PASS: Mesos patch 70044 was successfully built and tested.
Reviews applied: `['69977', '69978', '70044']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2924/mesos-review-70044
- Mesos Reviewbot Windows
On Feb. 23, 2019, 1:34 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70044/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 1:34 a.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9597
> https://issues.apache.org/jira/browse/MESOS-9597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the operation status update streams for operations
> affecting agent default resources from the root of the metadata
> directory to the agent's metadata directory, i.e.,
> `meta/operations/<operation_uuid>` to
> `meta/slaves/<slave_id/operations/<operation_uuid>`.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
> src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
> src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/70044/diff/1/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux + quite some manual testing.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 70044: Moved status update streams of operations on
agent's default resources.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70044/
-----------------------------------------------------------
(Updated Feb. 22, 2019, 5:34 p.m.)
Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
Bugs: MESOS-9597
https://issues.apache.org/jira/browse/MESOS-9597
Repository: mesos
Description
-------
This patch moves the operation status update streams for operations
affecting agent default resources from the root of the metadata
directory to the agent's metadata directory, i.e.,
`meta/operations/<operation_uuid>` to
`meta/slaves/<slave_id/operations/<operation_uuid>`.
Diffs
-----
src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df
src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f
src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70044/diff/1/
Testing (updated)
-------
Tests still pass on GNU/Linux + quite some manual testing.
Thanks,
Gastón Kleiman