You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/15 03:53:27 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #441:
HDDS-2889. Make DBStore and RDBStore more commons.
maobaolong opened a new pull request #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441
## What changes were proposed in this pull request?
As a user of RDBStore and TypedTable, i only use these class to maintain my rocksdb, i use hadoop-hdds-common as a maven dependency.
But during my progress running, i find a folder named `om.db.checkpoints`, it is terrible, i do not know om, i only want to use a common typedTable which help me maintains rocksdb.
So we should rename it, remove the concept of OM.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2889
## How was this patch tested?
Only change the name of checkpoint and comments, no need to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong edited a comment on issue #441:
HDDS-2889. Make DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
maobaolong edited a comment on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-574997029
@avijayanhwx Yeah, an option configuration item is needed.
And, how about create another jira ticket to track this issue, it maybe bring some more modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-574856822
@maobaolong Thanks for working on this.
I am thinking if we can create the checkpoints directory only if a checkpoint is requested? This will make sure we don't create this directory for any other component than OM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-574997029
@avijayanhwx Yeah, an option configuration item is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575958714
@maobaolong Maybe there was a misunderstanding. I did not mention anything about OM in DB checkpoint class. My point was that we can create the checkpoint directory inside the RDBCheckpoint manager, if someone requests a checkpoint. That way, we don't create empty directories in all instances of RDBStore being used by your tool or by ozone. I am perfectly OK to handle this in HDDS-2907. Thanks for filing the issue. +1 for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575260939
@maobaolong I believe it can be done without adding a config as well. Can we move the creation of the checkpoint parent directory inside **RDBCheckpointManager#createCheckpoint** ? That way, unless someone requests a checkpoint, the directory will not be created. Also, this is not really a "user" configurable item, It is just a code improvement. Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
elek closed pull request #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575974598
@avijayanhwx Sorry for the misunderstanding and your clarification, now i understand you and catch you key point, and i'm agree to move the checkpoint directory configuration and creation into RDBCheckpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575958579
@elek I have created another jira https://issues.apache.org/jira/browse/HDDS-2907.
If one RDBStore have only one RDBCheckpointManager, so there shouldn't have a name collision
If one RDBStore have more than one RDBCheckpointManager, we can give a index string as a suffix of the checkpoint folder name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #441: HDDS-2889. Make
DBStore and RDBStore more commons.
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #441: HDDS-2889. Make DBStore and RDBStore more commons.
URL: https://github.com/apache/hadoop-ozone/pull/441#issuecomment-575957910
@avijayanhwx I think we should neither bring the OM concept into `RDBStore` nor ` RDBCheckpointManager`, and we should let the user of `RDBStore` determine if checkpoint is enabled. Yes, i do agree that it maybe not a strong requests for let checkpoint folder to be a configurable item, we just give a hard code name for it, for example "db.checkpoint".
Because OM is a concept of Ozone, and `RDBStore` and ` RDBCheckpointManager` is a common components which is dependency by our program now, as a user of `RDBStore`, but not a user of Ozone, in fact, i do not need checkpoint at all in our scenario, but i think there must someone need checkpoint, and nobody want to specify the location or name of checkpoint folder now.
So, i think we should create another ticket https://issues.apache.org/jira/browse/HDDS-2907 for track our discussion？For `HDDS-2889`, we just remove the OM concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org