You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "HoustonPutman (via GitHub)" <gi...@apache.org> on 2026/01/21 17:46:58 UTC
[PR] SOLR-18081: ShardRequestTracker should use a unique key for requests [solr]
HoustonPutman opened a new pull request, #4068:
URL: https://github.com/apache/solr/pull/4068
https://issues.apache.org/jira/browse/SOLR-18081
Instead of indexing results by just the node name, the results should be indexed by node and replica, which is a unique key.
Also, when async is used, the failures and successes should be added just once to the result list. So a success in creating an Async request **will not** add a `success` response, it will wait for the actual async status to add that. But a failure in creating an Async request **will** add a `failure` response, because there will be no async status to add later. Currently a failed async request will add a `success` for the creation of the async request, and a `failure` or the status of the async request, which is very confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18081: ShardRequestTracker should use a unique key for requests [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on code in PR #4068:
URL: https://github.com/apache/solr/pull/4068#discussion_r2738374219
##########
changelog/unreleased/solr-18081-shard-request-tracker-replica-name.yml:
##########
@@ -0,0 +1,9 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: ShardRequestTracker should index results by node and replica rather than just node. This fixes requests that had multiple responses from a single node that got over-written.
Review Comment:
[0] There might be a way to rephrase this to make the impact a little more comprehensible to the average user. Maybe:
> Admin API responses now include the responses from *all* sub-requests, even in the case of colocated replicas.
Meh - now that I've written it up, I don't really like my alternative any better. It's a tough thing to convey concisely. Feel free to ignore me.
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -533,6 +577,15 @@ private static NamedList<Object> waitForCoreAdminAsyncCallToComplete(
}
continue;
+ } else if (r.equals("submitted")) {
Review Comment:
[+1] Great catch.
Obviously a different PR, but we should really convert this logic here and elsewhere into a switch-case, so we'll get warnings if we ever neglect to handle a particular value as we did here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18081: ShardRequestTracker should use a unique key for requests [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #4068:
URL: https://github.com/apache/solr/pull/4068#discussion_r2738823775
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -533,6 +577,15 @@ private static NamedList<Object> waitForCoreAdminAsyncCallToComplete(
}
continue;
+ } else if (r.equals("submitted")) {
Review Comment:
agreed, I think this logic could be cleaned up a lot. But I wanted to limit the scope of my PR, for obvious reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18081: ShardRequestTracker should use a unique key for requests [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #4068:
URL: https://github.com/apache/solr/pull/4068#discussion_r2738835423
##########
changelog/unreleased/solr-18081-shard-request-tracker-replica-name.yml:
##########
@@ -0,0 +1,9 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: ShardRequestTracker should index results by node and replica rather than just node. This fixes requests that had multiple responses from a single node that got over-written.
Review Comment:
Made it a bit better hopefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18081: ShardRequestTracker should use a unique key for requests [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman merged PR #4068:
URL: https://github.com/apache/solr/pull/4068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org