[GitHub] [ignite-3] AMashenkov commented on a change in pull request #411: IGNITE-15462 Replace usages of map of int to IntMap where possible in Calcite module.

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #411:
URL: https://github.com/apache/ignite-3/pull/411#discussion_r740247265



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/AbstractIgniteJoin.java
##########
@@ -304,9 +303,10 @@ protected boolean projectsLeft(RelCollation collation) {
         ImmutableIntList sourceKeys = left2Right ? joinInfo.leftKeys : joinInfo.rightKeys;
         ImmutableIntList targetKeys = left2Right ? joinInfo.rightKeys : joinInfo.leftKeys;
 
-        Map<Integer, Integer> keyMap = new HashMap<>();
+        Int2IntOpenHashMap keyMap = new Int2IntOpenHashMap(joinInfo.leftKeys.size());
+

Review comment:
       This change make no sense, a Mappings.target() will box, then unbox int values, in anyway. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org