You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2025/12/03 10:51:59 UTC
[PR] chore: test Scala 3 with `validatePullRequest` [pekko]
raboof opened a new pull request, #2544:
URL: https://github.com/apache/pekko/pull/2544
The Scala 3 build+test job takes almost an hour because it runs all tests, while the Scala 2 build+test job is sometimes much faster because it runs with `validatePullRequest` which selects which tests to run based on the files that were changed. I don't think we've regularly seen situations where a failure was missed by `validatePullRequest` and caught by the Scala 3 test, so it might be nice to run those with `validatePullRequest` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: test Scala 3 with `validatePullRequest` [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #2544:
URL: https://github.com/apache/pekko/pull/2544#discussion_r2584645177
##########
.github/workflows/build-test-prValidation.yml:
##########
@@ -57,6 +57,9 @@ jobs:
runs-on: ubuntu-22.04
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ strategy:
+ matrix:
+ scalaVersion: ["2.12.x", "3.3.x"]
Review Comment:
woops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: test Scala 3 with `validatePullRequest` [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #2544:
URL: https://github.com/apache/pekko/pull/2544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: test Scala 3 with `validatePullRequest` [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2544:
URL: https://github.com/apache/pekko/pull/2544#discussion_r2584636551
##########
.github/workflows/build-test-prValidation.yml:
##########
@@ -57,6 +57,9 @@ jobs:
runs-on: ubuntu-22.04
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ strategy:
+ matrix:
+ scalaVersion: ["2.12.x", "3.3.x"]
Review Comment:
2.13.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org