You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/23 06:09:17 UTC

[GitHub] zeppelin pull request #2178: [ZEPPELIN-2302] Add info level logs when instal...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2178

    [ZEPPELIN-2302] Add info level logs when installing node modules and bundling helium pkgs

    ### What is this PR for?
    
    Add info level logs when installing node modules and bundling helium packages.
    
    - Because your doesn't get noticed during 30secs ~ few minutes at all. This is usually (if you have multiple enabled helium packages)
    - User might think that Zeppelin hangs or there is other problem If there is no log message.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2302](https://issues.apache.org/jira/browse/ZEPPELIN-2302)
    
    ### How should this be tested?
    
    1. Enable some helium packages. 
    2. Then you will see log messages like
    
    ```
    INFO [2017-03-23 14:57:32,709] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:227) - Installing required node modules
    INFO [2017-03-23 14:57:36,561] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:233) - Installed required node modules
    INFO [2017-03-23 14:57:36,562] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:244) - Bundling helium packages
    INFO [2017-03-23 14:57:38,092] ({qtp1587067503-18} HeliumBundleFactory.java[buildBundle]:246) - Bundled helium packages
    ```
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2302/add-logging-for-helium

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2178
    
----
commit eda69af4e825ba494204a84a0f16748aaa25d518
Author: 1ambda <1a...@gmail.com>
Date:   2017-03-23T06:06:07Z

    chore: Add info level for helium bundling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2178
  
    Looks better :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2178
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2178: [ZEPPELIN-2302] Add info level logs when instal...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2178
  
    @felixcheung It's not that noisy. Because
    
    1. The logs occurs only when user enable / disable helium packages.
    2. And it is not usual action.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2178
  
    Merge to master if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---