You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/26 10:03:54 UTC

[PR] chore:test paradox failing [incubator-pekko]

He-Pin opened a new pull request, #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050

   used for testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913022921

   I verified both works @Roiocam 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1467748098


##########
docs/src/test/java-jdk9-only/jdocs/stream/operators/source/AsSubscriber.java:
##########
@@ -20,7 +20,7 @@
 import org.apache.pekko.NotUsed;
 import org.apache.pekko.stream.javadsl.Source;
 import org.apache.pekko.stream.javadsl.JavaFlowSupport;
-
+asdfasdfasdf

Review Comment:
   error code 



##########
.github/workflows/generate-paradox-check.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate paradox check
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  generate-doc-check:
+    name: Generate paradox check
+    runs-on: ubuntu-20.04
+    if: github.repository == 'apache/incubator-pekko'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          fetch-tags: true
+
+      - name: Setup Java 11
+        uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: 11
+
+      - name: Cache Coursier cache
+        uses: coursier/cache-action@v6.4.4
+
+      - name: Compile paradox documents
+        run: sbt ";clean ;Test / compile ;TestJdk9 / compile ;docs/paradox"

Review Comment:
   `TestJdk9 / compile`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913128086

   @pjfanning I'm mean the file is been compiled in the doc. Check the JDK9+ classes generated is not a target of this PR. Why do you always like to block a PR? you can just leave a comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913010895

   @Roiocam Let's me update the pr and check if that works on ci too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913140117

   > ![image](https://private-user-images.githubusercontent.com/501740/300174670-4bfe4b27-d2d2-4fb1-8b43-010e5e1bb614.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDYzNTc4MzIsIm5iZiI6MTcwNjM1NzUzMiwicGF0aCI6Ii81MDE3NDAvMzAwMTc0NjcwLTRiZmU0YjI3LWQyZDItNGZiMS04YjQzLTAxMGU1ZTFiYjYxNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDEyN1QxMjEyMTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MDE2NWRjMDdmMDQ1MDU1MDM0Nzg3MmZkMzZmNzE4OGNmMWVhZmY5NDU1YmI1ZDM5YTc1NmNiMmUzMWVkNmE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.dG9HlUCSrpzMZ4ONYNYr7WcWgVUOlpKrugQ_0N7Ln8A)
   
   @pjfanning Now it will check the error. as ↑ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913152907

   @pjfanning @He-Pin 
   
   I have created an issue tracker for those build problems: #1052
   
   I think this issue only related to #959
   
   And #1039 has been fixed by #1047


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1911910562

   @Roiocam I just checked, the paradox task still can't catch the compiling error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913138446

   @pjfanning Because you forgot https://github.com/apache/incubator-pekko/pull/958 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913139820

   > @pjfanning Because you forgot #958
   
   It is the duty of the PR writer to explain their PR. You made no mention of #958 and claimed this is to be a fix for #1040 - which it isn't.
   
   Can you now explain how this change helps with #958?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913134736

   @pjfanning I'm preparing a PR for https://github.com/apache/incubator-pekko/issues/1039, separately. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1912191799

   @mdedetrich @pjfanning @Roiocam 
   I think this should be the simplest way.
   With an explicit `TestJDK9 / test` as I chatted with @Roiocam on WeChat.
   https://github.com/apache/incubator-pekko/actions/runs/7669498804/job/20903555947?pr=1050#step:5:688
   
   
   I tried to rewrite the plugin which just replaced the `Test / unmanagedSourceDirectieries`, but it will need to change more code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468448424


##########
.github/workflows/generate-paradox-check.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate paradox check
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  generate-doc-check:
+    name: Generate paradox check
+    runs-on: ubuntu-20.04
+    if: github.repository == 'apache/incubator-pekko'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          fetch-tags: true
+
+      - name: Setup Java 11
+        uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: 11
+
+      - name: Cache Coursier cache
+        uses: coursier/cache-action@v6.4.4
+
+      - name: Compile paradox documents
+        run: sbt ";clean ;Test / compile ;TestJdk9 / compile ;docs/paradox"

Review Comment:
   I can move this to `Generate doc check / Generate doc check (pull_request)` task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1912497767

   `clean;docs/test` works for me too, I think we need to figure out why `validatePullRequest` rather than adding a CI check, what do you think? @He-Pin 
   
   ```
   [info] compiling 2 Scala sources and 2 Java sources to /Users/roiocam/IdeaProject/incubator-pekko/docs/target/scala-2.13/TestJdk9-classes ...
   [error] /Users/roiocam/IdeaProject/incubator-pekko/docs/src/test/java-jdk9-only/jdocs/stream/operators/source/AsSubscriber.java:26:1: illegal start of type declaration
   [error] public interface AsSubscriber {
   [error] ^
   [error] one error found
   [info] Run completed in 1 minute, 18 seconds.
   [info] Total number of tests run: 629
   [info] Suites: completed 181, aborted 0
   [info] Tests: succeeded 629, failed 0, canceled 0, ignored 6, pending 1
   [info] All tests passed.
   [error] (docs / TestJdk9 / compileIncremental) Compilation failed
   [error] Total time: 349 s (05:49), completed 2024年1月27日 上午2:19:19
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468447996


##########
.github/workflows/generate-paradox-check.yml:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generate paradox check
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  generate-doc-check:
+    name: Generate paradox check
+    runs-on: ubuntu-20.04
+    if: github.repository == 'apache/incubator-pekko'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          fetch-tags: true
+
+      - name: Setup Java 11
+        uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: 11
+
+      - name: Cache Coursier cache
+        uses: coursier/cache-action@v6.4.4
+
+      - name: Compile paradox documents
+        run: sbt ";clean ;Test / compile ;TestJdk9 / compile ;docs/paradox"

Review Comment:
   can we do this as part of https://github.com/apache/incubator-pekko/blob/main/.github/workflows/binary-compatibility-checks.yml - to avoid have an extra job?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913125468

   It can now check the error code in Java 9 folder, and for Java 21 I will do in another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468464710


##########
.github/workflows/generate-doc-check.yml:
##########
@@ -48,5 +48,5 @@ jobs:
         run: |-
           sudo apt-get install graphviz
 
-      - name: Compile docs for all Scala versions
-        run: sbt +compile:doc
+      - name: Compile docs&paradox for all Scala versions
+        run: sbt ";Test / compile ;TestJdk9 / compile ;docs/paradox ;+compile:doc"

Review Comment:
   ```suggestion
         - name: Compile testClass&docs for all Scala versions
           run: sbt ";TestJdk9 / compile ; +compile:doc"
   ```
   
   `TestJdk9 / compile` extended from `Test / compile`, I think we could simplify, I have verified in locally.
   
   
   ```
   [info] compiling 1 Scala source to /Users/roiocam/IdeaProject/incubator-pekko/cluster-sharding/target/scala-2.13/test-classes ...
   [info] compiling 3 Scala sources and 3 Java sources to /Users/roiocam/IdeaProject/incubator-pekko/docs/target/scala-2.13/test-classes ...
   [info] compiling 1 Java source to /Users/roiocam/IdeaProject/incubator-pekko/docs/target/scala-2.13/test-classes ...
   [info] compiling 2 Scala sources and 2 Java sources to /Users/roiocam/IdeaProject/incubator-pekko/docs/target/scala-2.13/TestJdk9-classes ...
   
   ```
   
   And `docs/paradox` doesn't verify anything for #959, and `validaPullRequest` has covered it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913134133

   > @pjfanning I mean the file is been compiled in the doc. Check the JDK9+ classes generated is not a target of this PR. Why do you always like to block a PR? you can just leave a comment.
   
   https://github.com/apache/incubator-pekko/issues/1039 isn't even fixed yet - what we really need is to fix https://github.com/apache/incubator-pekko/issues/1039 and then come up with a CI check that stops https://github.com/apache/incubator-pekko/issues/1039 ever happening again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913136813

   > Motivation:
   > Fix #1040
   
   I don't understand this PR at all. #1040 relates to #1039. How is this a fix for #1040?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore:test paradox failing [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913123773

   ![image](https://github.com/apache/incubator-pekko/assets/501740/4bfe4b27-d2d2-4fb1-8b43-010e5e1bb614)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org