You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ki...@apache.org on 2019/12/26 21:49:40 UTC
[incubator-pinot] branch shaded-plugin-jars created (now 2d92b9d)
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch shaded-plugin-jars
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 2d92b9d Adding profile goal to generate shaded jars for all plugins automatically
This branch includes the following new commits:
new 2d92b9d Adding profile goal to generate shaded jars for all plugins automatically
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[incubator-pinot] 01/01: Adding profile goal to generate shaded
jars for all plugins automatically
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a commit to branch shaded-plugin-jars
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 2d92b9d8a5731b956141fe6a042aaf5328f1de2a
Author: kishoreg <g....@gmail.com>
AuthorDate: Thu Dec 26 13:49:03 2019 -0800
Adding profile goal to generate shaded jars for all plugins automatically
---
.../pinot-batch-ingestion-base/pom.xml | 50 ----------------------
pinot-plugins/pinot-file-system/pinot-gcs/pom.xml | 19 --------
.../pinot-input-format/pinot-avro/pom.xml | 27 ------------
pinot-plugins/pinot-input-format/pinot-csv/pom.xml | 27 ------------
.../pinot-input-format/pinot-json/pom.xml | 27 ------------
pinot-plugins/pinot-input-format/pinot-orc/pom.xml | 27 ------------
.../pinot-input-format/pinot-parquet/pom.xml | 27 ------------
.../pinot-input-format/pinot-thrift/pom.xml | 27 ------------
pinot-plugins/pinot-input-format/pom.xml | 5 ---
pinot-plugins/pom.xml | 28 +++++++++++-
10 files changed, 27 insertions(+), 237 deletions(-)
diff --git a/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-base/pom.xml b/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-base/pom.xml
index 5f0a565..80c06f8 100644
--- a/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-base/pom.xml
+++ b/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-base/pom.xml
@@ -35,56 +35,6 @@
<properties>
<pinot.root>${basedir}/../../..</pinot.root>
</properties>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>false</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <!--
- Usually in hadoop environment, there are multiple jars with different versions.
- Most of the NoSuchMethodExceptions are caused by class loading conflicts.
- Class relocation ensures the reference of certain packages/classes in Pinot code to
- shaded libs, e.g. jackson or guava.
- Ref: https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html
- -->
- <relocations>
- <relocation>
- <pattern>com.google.common.base</pattern>
- <shadedPattern>shaded.com.google.common.base</shadedPattern>
- </relocation>
- <relocation>
- <pattern>com.fasterxml.jackson</pattern>
- <shadedPattern>shaded.com.fasterxml.jackson</shadedPattern>
- </relocation>
- </relocations>
- <transformers>
- <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
- <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
- <mainClass>org.apache.pinot.ingestion.standalone.StandaloneIngestionJobLauncher</mainClass>
- </transformer>
- </transformers>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
-
<dependencies>
<dependency>
<groupId>org.apache.pinot</groupId>
diff --git a/pinot-plugins/pinot-file-system/pinot-gcs/pom.xml b/pinot-plugins/pinot-file-system/pinot-gcs/pom.xml
index f581d27..fcf5878 100644
--- a/pinot-plugins/pinot-file-system/pinot-gcs/pom.xml
+++ b/pinot-plugins/pinot-file-system/pinot-gcs/pom.xml
@@ -54,23 +54,4 @@
<scope>test</scope>
</dependency>
</dependencies>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <shadedArtifactAttached>false</shadedArtifactAttached>
- <createDependencyReducedPom>false</createDependencyReducedPom>
- </configuration>
- </plugin>
- </plugins>
- </build>
</project>
diff --git a/pinot-plugins/pinot-input-format/pinot-avro/pom.xml b/pinot-plugins/pinot-input-format/pinot-avro/pom.xml
index 192de75..44e9399 100644
--- a/pinot-plugins/pinot-input-format/pinot-avro/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-avro/pom.xml
@@ -42,33 +42,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-avro</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.apache.avro</groupId>
diff --git a/pinot-plugins/pinot-input-format/pinot-csv/pom.xml b/pinot-plugins/pinot-input-format/pinot-csv/pom.xml
index ed82302..2e20fad 100644
--- a/pinot-plugins/pinot-input-format/pinot-csv/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-csv/pom.xml
@@ -42,33 +42,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-csv</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/pinot-plugins/pinot-input-format/pinot-json/pom.xml b/pinot-plugins/pinot-input-format/pinot-json/pom.xml
index 42c2f98..06b0a88 100644
--- a/pinot-plugins/pinot-input-format/pinot-json/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-json/pom.xml
@@ -42,33 +42,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-json</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/pinot-plugins/pinot-input-format/pinot-orc/pom.xml b/pinot-plugins/pinot-input-format/pinot-orc/pom.xml
index 998f928..bf41572 100644
--- a/pinot-plugins/pinot-input-format/pinot-orc/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-orc/pom.xml
@@ -43,33 +43,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-orc</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.apache.orc</groupId>
diff --git a/pinot-plugins/pinot-input-format/pinot-parquet/pom.xml b/pinot-plugins/pinot-input-format/pinot-parquet/pom.xml
index 68ee6c7..f3d06d9 100644
--- a/pinot-plugins/pinot-input-format/pinot-parquet/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-parquet/pom.xml
@@ -42,33 +42,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-parquet</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.apache.pinot</groupId>
diff --git a/pinot-plugins/pinot-input-format/pinot-thrift/pom.xml b/pinot-plugins/pinot-input-format/pinot-thrift/pom.xml
index b6607b4..e5b0903 100644
--- a/pinot-plugins/pinot-input-format/pinot-thrift/pom.xml
+++ b/pinot-plugins/pinot-input-format/pinot-thrift/pom.xml
@@ -42,33 +42,6 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <id>build-shaded-jar</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <outputDirectory>target/plugins/record-readers/pinot-thrift</outputDirectory>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
<dependencies>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/pinot-plugins/pinot-input-format/pom.xml b/pinot-plugins/pinot-input-format/pom.xml
index 4e69b5b..d4a2af4 100644
--- a/pinot-plugins/pinot-input-format/pom.xml
+++ b/pinot-plugins/pinot-input-format/pom.xml
@@ -47,11 +47,6 @@
</modules>
<dependencies>
- <dependency>
- <groupId>org.apache.pinot</groupId>
- <artifactId>pinot-spi</artifactId>
- <scope>provided</scope>
- </dependency>
<!-- test -->
<dependency>
<groupId>org.testng</groupId>
diff --git a/pinot-plugins/pom.xml b/pinot-plugins/pom.xml
index c97e6e7..716e5e8 100644
--- a/pinot-plugins/pom.xml
+++ b/pinot-plugins/pom.xml
@@ -56,5 +56,31 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+ <profiles>
+ <profile>
+ <id>build-shaded-jar</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.2.1</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <outputDirectory>target/plugins/${artifactId}</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ </profiles>
</project>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org