You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/29 06:52:05 UTC
[GitHub] [shardingsphere] zjcnb opened a new issue, #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
zjcnb opened a new issue, #18687:
URL: https://github.com/apache/shardingsphere/issues/18687
Hi community,
We recently refactor `readwrite-splitting` feature `API`, you can refer to #18587, #18629.
Currently showing results when you use `dynamic strategy` :
```
mysql> show readwrite_splitting rules from readwrite_splitting_db;
+--------------+-----------------------------+------------------------+------------------------+--------------------+---------------------+
| name | auto_aware_data_source_name | write_data_source_name | read_data_source_names | load_balancer_type | load_balancer_props |
+--------------+-----------------------------+------------------------+------------------------+--------------------+---------------------+
| readwrite_ds | ms_group_0 | ds_0 | ds_1,ds_2 | | |
+-------+------------------------------------+------------------------+------------------------+--------------------+---------------------+
```
It's missing the `write_data_source_query_enabled` parameter.
Task list :
- [ ] Modify `ReadwriteSplittingRuleQueryResultSet.class` to add `write_data_source_query_enabled` parameter.
- [ ] Fix `ReadwriteSplittingRuleQueryResultSetTest.class` unit test.
- [ ] Fix `shardingsphere-integration-test` module.
1. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rdl/dataset/empty_rules/alter_readwrite_splitting_rules.xml`
2. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rdl/dataset/empty_rules/create_readwrite_splitting_rules.xml`
3. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rdl/dataset/empty_rules/drop_readwrite_splitting_rules.xml`
4. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rql/dataset/dbtbl_with_readwrite_splitting/show_readwrite_splitting_rules.xml`
5. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rql/dataset/dbtbl_with_readwrite_splitting_and_encrypt/show_readwrite_splitting_rules.xml`
6. `shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/rql/dataset/readwrite_splitting/show_readwrite_splitting_rules.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] chakkk309 commented on issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on issue #18687:
URL: https://github.com/apache/shardingsphere/issues/18687#issuecomment-1169680476
Hi, I want to have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #18687:
URL: https://github.com/apache/shardingsphere/issues/18687#issuecomment-1169709450
> Hi, I want to have a try.
We need to finish it in 5.1.3 milestone, so we need to hurry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] chakkk309 commented on issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on issue #18687:
URL: https://github.com/apache/shardingsphere/issues/18687#issuecomment-1170050777
> > Hi, I want to have a try.
>
> We need to finish it in 5.1.3 milestone, so we need to hurry.
OK, I'll sync the progress to finish on time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #18687:
URL: https://github.com/apache/shardingsphere/issues/18687#issuecomment-1169684682
> Hi, I want to have a try.
Welcome, assign you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb closed issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by GitBox <gi...@apache.org>.
zjcnb closed issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
URL: https://github.com/apache/shardingsphere/issues/18687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #18687: [DistSQL] READWRITE_SPLITTING RULES need to show `write_data_source_query_enabled` query results
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #18687:
URL: https://github.com/apache/shardingsphere/issues/18687#issuecomment-1442804205
Ref : #18587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org