[jira] [Commented] (AMQ-6880) Incorrect comparison behaviour in TransportConnector.isMatchesCluster with Tokenised Filter

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309843#comment-16309843 ] 

ASF subversion and git services commented on AMQ-6880:
------------------------------------------------------

Commit 8c77e9553eaf2062b937c68737a5128d0f9a4347 in activemq's branch refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=8c77e95 ]

[AMQ-6880] fix filter match logic when transport connector updateClusterFilter is in play


> Incorrect comparison behaviour in TransportConnector.isMatchesCluster with Tokenised Filter
> -------------------------------------------------------------------------------------------
>
>                 Key: AMQ-6880
>                 URL: https://issues.apache.org/jira/browse/AMQ-6880
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.15.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>             Fix For: 5.16.0
>
>
> the clusterFilter should support a comma-delimited list of filter expressions.
> Consider a use case where we have brokers with prefixes, like east and west and we have specified a broker filter of "east.*,west.*"
> We add a new broker to the network, called "west-broker2." Looking at the code, this expression will fail out on the first test (against the "east.* filter token), setting result to false and failing to add the broker.
> Similarly, if we add a new broker called "east-broker2," the name will successfully test against the first filter token of "east.*", then will subsequently fail against the following token of "west.*" instead of breaking out.
> When a filter is set, we need to check for a match against all of the tokens in the filter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)