[GitHub] jlahoda commented on a change in pull request #468: nb-javac jars upgrade for NETBEANS-463 fix

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #468: nb-javac jars upgrade for NETBEANS-463 fix 
URL: https://github.com/apache/incubator-netbeans/pull/468#discussion_r187619231
 
 

 ##########
 File path: java.source.base/test/unit/src/org/netbeans/api/java/source/TreePathHandleTest.java
 ##########
 @@ -422,6 +427,34 @@ public void testLocVar() throws Exception {
         assertNotNull(handle.resolveElement(info));
     }
 
+    public void testVarInstanceMember() throws Exception {
+        try {
+            SourceVersion.valueOf("RELEASE_10"); //NOI18N
 
 Review comment:
   This does not appear to be wrong, and is actually OK, although probably not absolutely necessary: when running tests with nb-javac (which understands vars), SourceVersion from nb-javac is used, which has RELEASE_10. If we would run the test with vanilla javac on JDK 10, then the constant would exist as well. The only case when the constant does not exist, I think, is when running the tests with vanilla javac (without nb-javac) on JDK 9, which does not understand vars and it would be OK/good to skip the test. But I doubt we would be doing that, so this check is nice, but not absolutely necessary, I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists