You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/04 16:40:03 UTC
[GitHub] [beam] AydarZaynutdinov opened a new pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
AydarZaynutdinov opened a new pull request #17016:
URL: https://github.com/apache/beam/pull/17016
[BEAM-14049]
Add and implement new API method to get Precompiled Object by cloud path
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #17016:
URL: https://github.com/apache/beam/pull/17016#issuecomment-1072903345
lgtm thanks. Can you please add more detail in the bug (BEAM-14049) as to why this is necessary? (I suppose the backend needs to get the examples for the catalog. this will be useful in the future for maintenance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on pull request #17016:
URL: https://github.com/apache/beam/pull/17016#issuecomment-1059325512
R: @KhaninArtur @ilya-kozyrev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on a change in pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #17016:
URL: https://github.com/apache/beam/pull/17016#discussion_r822345343
##########
File path: playground/api/v1/api.proto
##########
@@ -274,6 +284,9 @@ service PlaygroundService {
// Get all precompiled objects from the cloud storage.
rpc GetPrecompiledObjects(GetPrecompiledObjectsRequest) returns (GetPrecompiledObjectsResponse);
+ // Get precompiled objects from the cloud storage.
Review comment:
```suggestion
// Get precompiled object from the cloud storage.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #17016:
URL: https://github.com/apache/beam/pull/17016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on pull request #17016:
URL: https://github.com/apache/beam/pull/17016#issuecomment-1067850116
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #17016:
URL: https://github.com/apache/beam/pull/17016#discussion_r822400735
##########
File path: playground/api/v1/api.proto
##########
@@ -274,6 +284,9 @@ service PlaygroundService {
// Get all precompiled objects from the cloud storage.
rpc GetPrecompiledObjects(GetPrecompiledObjectsRequest) returns (GetPrecompiledObjectsResponse);
+ // Get precompiled objects from the cloud storage.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on pull request #17016: [BEAM-14049][Playground] Add new API method to get Precompiled Object
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on pull request #17016:
URL: https://github.com/apache/beam/pull/17016#issuecomment-1063067981
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org