You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/02 13:24:49 UTC
[GitHub] [kafka] yashmayya opened a new pull request, #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
yashmayya opened a new pull request, #12472:
URL: https://github.com/apache/kafka/pull/12472
https://issues.apache.org/jira/browse/KAFKA-14134
From https://issues.apache.org/jira/browse/KAFKA-7438:
> Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and are not actively maintained. In addition, Mockito is also easier to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
yashmayya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r941154092
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -672,6 +452,27 @@ protected void assertInitializedMetric(WorkerConnector workerConnector, String e
assertEquals(VERSION, version);
}
+ @SuppressWarnings("unchecked")
+ private Callback<TargetState> mockCallback() {
+ return mock(Callback.class);
+ }
+
+ private void verifyCleanInitialize() {
+ verify(connector).version();
+ if (connector instanceof SourceConnector) {
+ verify(offsetStore).start();
+ verify(connector).initialize(any(SourceConnectorContext.class));
+ } else {
+ verify(connector).initialize(any(SinkConnectorContext.class));
+ }
+ }
+
+ private void verifyCleanShutdown() {
+ verify(ctx).close();
+ verify(offsetStorageReader).close();
Review Comment:
Good catch, thanks! I just translated the tests as is and hadn't noticed that we were passing non-null offset storage reader and offset backing stores instances even for sink connectors in these tests (differing in behavior with how the actual `Worker` instantiates `WorkerConnector`s).
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +105,21 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verifyCleanInitialize();
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
Review Comment:
The one for shutdown makes sense but I think with startup there are three different cases -
i) No call to `connector.start` or `listener.onStartup` (failure in initialization OR started in the paused state)
ii) Calls to both `connector.start` and `listener.onStartup` (successful start)
iii) Call to only `connector.start` (connector started in the paused state and then resumed OR failure on startup)
I think it might be more readable to keep these verify calls in the test methods as is rather than trying to force fit them into (in)appropriately named methods, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935646206
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -26,28 +26,32 @@
import org.apache.kafka.connect.source.SourceConnectorContext;
import org.apache.kafka.connect.storage.CloseableOffsetStorageReader;
import org.apache.kafka.connect.storage.ConnectorOffsetBackingStore;
-import org.easymock.Capture;
import org.apache.kafka.connect.util.Callback;
-import org.easymock.EasyMock;
-import org.easymock.EasyMockRunner;
-import org.easymock.EasyMockSupport;
-import org.easymock.Mock;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import org.junit.runner.RunWith;
import java.util.HashMap;
import java.util.Map;
+import org.mockito.ArgumentCaptor;
+import org.mockito.InOrder;
-import static org.easymock.EasyMock.expectLastCall;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
-
-@RunWith(EasyMockRunner.class)
Review Comment:
You might want to consider using `MockitoJUnitRunner.StrictStubs` since it comes with a lot of benefits highlighted in the docs https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/junit/MockitoJUnitRunner.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
yashmayya commented on PR #12472:
URL: https://github.com/apache/kafka/pull/12472#issuecomment-1202563314
@mimaison or @C0urante could you please take a look? The changes are fairly straightforward for this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935609616
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends EasyMockSupport {
public ConnectorConfig connectorConfig;
public MockConnectMetrics metrics;
- @Mock Plugins plugins;
- @Mock SourceConnector sourceConnector;
- @Mock SinkConnector sinkConnector;
- @Mock Connector connector;
- @Mock CloseableConnectorContext ctx;
- @Mock ConnectorStatus.Listener listener;
- @Mock CloseableOffsetStorageReader offsetStorageReader;
- @Mock ConnectorOffsetBackingStore offsetStore;
- @Mock ClassLoader classLoader;
+ private final Plugins plugins = mock(Plugins.class);
+ private final SourceConnector sourceConnector = mock(SourceConnector.class);
+ private final SinkConnector sinkConnector = mock(SinkConnector.class);
+ private final CloseableConnectorContext ctx = mock(CloseableConnectorContext.class);
+ private final ConnectorStatus.Listener listener = mock(ConnectorStatus.Listener.class);
+ private final CloseableOffsetStorageReader offsetStorageReader = mock(CloseableOffsetStorageReader.class);
+ private final ConnectorOffsetBackingStore offsetStore = mock(ConnectorOffsetBackingStore.class);
+ private final ClassLoader classLoader = mock(ClassLoader.class);
+ private Connector connector;
Review Comment:
Is there a reason that this field is a member? Perhaps we could use a local variable in each of the test for this.
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -86,31 +90,8 @@ public void testInitializeFailure() {
RuntimeException exception = new RuntimeException();
connector = sourceConnector;
- connector.version();
- expectLastCall().andReturn(VERSION);
-
- offsetStore.start();
Review Comment:
I am adding this comment here to help other reviewers in reviewing the changes in these lines.
It is ok to remove these void calls because Mockito automatically creates stubs for void method calls. As long as we are verifying that they are being invoked, we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12472:
URL: https://github.com/apache/kafka/pull/12472#issuecomment-1205526845
Looks good from my side!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
yashmayya commented on PR #12472:
URL: https://github.com/apache/kafka/pull/12472#issuecomment-1203578055
Thanks for the reviews @divijvaidya and @C0urante! I've incorporated your feedback, could you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r940418956
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +105,21 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verifyCleanInitialize();
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
Review Comment:
Almost every call to `verifyCleanShutdown` is preceded by a check to verify that `listener::onShutdown` was invoked. Could we add this logic to `verifyCleanShutdown`? Thinking of something like this:
```java
private void verifyCleanShutdown() {
verifyShutdown(true);
}
private void verifyShutdown(boolean clean) {
verify(ctx).close();
verify(offsetStorageReader).close();
verify(offsetStore).stop();
if (clean) {
verify(listener).onShutdown(CONNECTOR);
}
}
```
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -672,6 +452,27 @@ protected void assertInitializedMetric(WorkerConnector workerConnector, String e
assertEquals(VERSION, version);
}
+ @SuppressWarnings("unchecked")
+ private Callback<TargetState> mockCallback() {
+ return mock(Callback.class);
+ }
+
+ private void verifyCleanInitialize() {
+ verify(connector).version();
+ if (connector instanceof SourceConnector) {
+ verify(offsetStore).start();
+ verify(connector).initialize(any(SourceConnectorContext.class));
+ } else {
+ verify(connector).initialize(any(SinkConnectorContext.class));
+ }
+ }
+
+ private void verifyCleanShutdown() {
+ verify(ctx).close();
+ verify(offsetStorageReader).close();
Review Comment:
This is a little unrealistic since we should only be supplying non-null offset readers for source connectors. Can we correct that logic while we're in the neighborhood?
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +105,21 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verifyCleanInitialize();
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
Review Comment:
We can also follow a similar approach with startup logic. This would involve renaming `verifyCleanInitialize` to `verifyStartup` and adding a `clean` parameter to the method:
```java
private void verifyCleanStartup() {
verifyStartup(true);
}
private void verifyStartup(boolean clean) {
verify(connector).version();
if (connector instanceof SourceConnector) {
verify(offsetStore).start();
verify(connector).initialize(any(SourceConnectorContext.class));
} else {
verify(connector).initialize(any(SinkConnectorContext.class));
}
if (clean) {
verify(connector).start(CONFIG);
verify(listener).onStartup(CONNECTOR);
}
}
```
(`clean` isn't the most accurate term here since there are clean startups in the paused state that would involve passing `false` for that parameter; feel free to replace with something better)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935923454
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +101,26 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verify(connector).version();
+ verify(offsetStore).start();
+ verify(connector).initialize(any(SourceConnectorContext.class));
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
+ verify(ctx).close();
+ verify(offsetStorageReader).close();
+ verify(offsetStore).stop();
}
@Test
public void testFailureIsFinalState() {
RuntimeException exception = new RuntimeException();
connector = sinkConnector;
- connector.version();
- expectLastCall().andReturn(VERSION);
-
- connector.initialize(EasyMock.notNull(SinkConnectorContext.class));
- expectLastCall().andThrow(exception);
-
- listener.onFailure(CONNECTOR, exception);
- expectLastCall();
-
- // expect no call to onStartup() after failure
-
- listener.onShutdown(CONNECTOR);
- expectLastCall();
-
- ctx.close();
- expectLastCall();
-
- offsetStorageReader.close();
- expectLastCall();
-
- offsetStore.stop();
- expectLastCall();
-
- Callback<TargetState> onStateChange = createStrictMock(Callback.class);
- onStateChange.onCompletion(EasyMock.anyObject(Exception.class), EasyMock.isNull());
- expectLastCall();
-
- replayAll();
+ when(connector.version()).thenReturn(VERSION);
+ doThrow(exception).when(connector).initialize(any());
+ @SuppressWarnings("unchecked")
+ Callback<TargetState> onStateChange = mock(Callback.class);
Review Comment:
What do you think about introducing a utility method so that creating callbacks like these can be done without having to add the `@SuppressWarnings` annotation?
I'm thinking something like this:
```java
@SuppressWarnings("unchecked")
private Callback<TargetState> mockCallback() {
return mock(Callback.class);
}
```
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends EasyMockSupport {
public ConnectorConfig connectorConfig;
public MockConnectMetrics metrics;
- @Mock Plugins plugins;
- @Mock SourceConnector sourceConnector;
- @Mock SinkConnector sinkConnector;
- @Mock Connector connector;
- @Mock CloseableConnectorContext ctx;
- @Mock ConnectorStatus.Listener listener;
- @Mock CloseableOffsetStorageReader offsetStorageReader;
- @Mock ConnectorOffsetBackingStore offsetStore;
- @Mock ClassLoader classLoader;
+ private final Plugins plugins = mock(Plugins.class);
Review Comment:
Can we use the `@Mock` annotation for these?
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +101,26 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verify(connector).version();
+ verify(offsetStore).start();
+ verify(connector).initialize(any(SourceConnectorContext.class));
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
+ verify(ctx).close();
+ verify(offsetStorageReader).close();
+ verify(offsetStore).stop();
Review Comment:
I know that this complexity isn't introduced by these changes, and is only translated from the existing EasyMock/PowerMock tests, but it'd be nice if we could try to clean up this logic while we're in the neighborhood.
Would you mind taking a stab at grouping some of these together into reusable methods, like `verifyCleanStart`, `verifyCleanShutdown`, etc.? I tried to do that in https://github.com/apache/kafka/pull/12409 if you're looking for inspiration, but you don't have to match that exact style if you have other ideas/preferences.
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -275,52 +197,31 @@ public void testStartupAndPause() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verify(connector).version();
+ verify(connector).initialize(any(SinkConnectorContext.class));
+ verify(connector).start(CONFIG);
+ verify(listener).onStartup(CONNECTOR);
+ verify(connector).stop();
+ verify(listener).onPause(CONNECTOR);
+ verify(listener).onShutdown(CONNECTOR);
+ verify(ctx).close();
+ verify(offsetStorageReader).close();
+ verify(offsetStore).stop();
+
+ InOrder inOrder = inOrder(onStateChange);
+ inOrder.verify(onStateChange).onCompletion(isNull(), eq(TargetState.STARTED));
+ inOrder.verify(onStateChange).onCompletion(isNull(), eq(TargetState.PAUSED));
+ verifyNoMoreInteractions(onStateChange);
Review Comment:
Very nice 👍
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends EasyMockSupport {
public ConnectorConfig connectorConfig;
public MockConnectMetrics metrics;
- @Mock Plugins plugins;
- @Mock SourceConnector sourceConnector;
- @Mock SinkConnector sinkConnector;
- @Mock Connector connector;
- @Mock CloseableConnectorContext ctx;
- @Mock ConnectorStatus.Listener listener;
- @Mock CloseableOffsetStorageReader offsetStorageReader;
- @Mock ConnectorOffsetBackingStore offsetStore;
- @Mock ClassLoader classLoader;
+ private final Plugins plugins = mock(Plugins.class);
+ private final SourceConnector sourceConnector = mock(SourceConnector.class);
+ private final SinkConnector sinkConnector = mock(SinkConnector.class);
+ private final CloseableConnectorContext ctx = mock(CloseableConnectorContext.class);
+ private final ConnectorStatus.Listener listener = mock(ConnectorStatus.Listener.class);
+ private final CloseableOffsetStorageReader offsetStorageReader = mock(CloseableOffsetStorageReader.class);
+ private final ConnectorOffsetBackingStore offsetStore = mock(ConnectorOffsetBackingStore.class);
+ private final ClassLoader classLoader = mock(ClassLoader.class);
+ private Connector connector;
Review Comment:
I think it helps with readability a bit. We always need a `Connector` for our tests. The reason we can't use the `@Mock` annotation for it is just that we always use either the (mocked) `SourceConnector` or `SinkConnector`.
Also worth noting that if https://github.com/apache/kafka/pull/12307 lands, a class-level `Connector` would be easier to work with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r941388856
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -120,43 +105,21 @@ public void testInitializeFailure() {
workerConnector.doShutdown();
assertStoppedMetric(workerConnector);
- verifyAll();
+ verifyCleanInitialize();
+ verify(listener).onFailure(CONNECTOR, exception);
+ verify(listener).onShutdown(CONNECTOR);
Review Comment:
Yeah, that's fair. LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
C0urante merged PR #12472:
URL: https://github.com/apache/kafka/pull/12472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r936433188
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends EasyMockSupport {
public ConnectorConfig connectorConfig;
public MockConnectMetrics metrics;
- @Mock Plugins plugins;
- @Mock SourceConnector sourceConnector;
- @Mock SinkConnector sinkConnector;
- @Mock Connector connector;
- @Mock CloseableConnectorContext ctx;
- @Mock ConnectorStatus.Listener listener;
- @Mock CloseableOffsetStorageReader offsetStorageReader;
- @Mock ConnectorOffsetBackingStore offsetStore;
- @Mock ClassLoader classLoader;
+ private final Plugins plugins = mock(Plugins.class);
+ private final SourceConnector sourceConnector = mock(SourceConnector.class);
+ private final SinkConnector sinkConnector = mock(SinkConnector.class);
+ private final CloseableConnectorContext ctx = mock(CloseableConnectorContext.class);
+ private final ConnectorStatus.Listener listener = mock(ConnectorStatus.Listener.class);
+ private final CloseableOffsetStorageReader offsetStorageReader = mock(CloseableOffsetStorageReader.class);
+ private final ConnectorOffsetBackingStore offsetStore = mock(ConnectorOffsetBackingStore.class);
+ private final ClassLoader classLoader = mock(ClassLoader.class);
+ private Connector connector;
Review Comment:
ok, I don't have strong opinion on this one. We can keep it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org