You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/12 09:38:59 UTC
[GitHub] [incubator-doris] gtchaos opened a new pull request, #9524: libhdfs3 built enable kerberos support
gtchaos opened a new pull request, #9524:
URL: https://github.com/apache/incubator-doris/pull/9524
# Proposed changes
Issue Number: close #9515
## Problem Summary:
Currently, the libhdfs3 library integrated by doris BE does not support accessing the cluster with kerberos authentication enabled, and found that kerberos-related dependencies（gsasl and krb5） were not added when build libhdfs3.
so, this pr will enable kerberos support and rebuild libhdfs3 with dependencies gsasl and krb5:
- gsasl version: 1.8.0
- krb5 version: 1.19
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (Yes)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9524: [Feature] libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524#issuecomment-1131465851
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9524: libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524#issuecomment-1124984958
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9524: [Feature] libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524#discussion_r876019680
##########
thirdparty/build-thirdparty.sh:
##########
@@ -904,16 +904,46 @@ build_gsasl() {
make -j $PARALLEL && make install
}
+# build_gsasl2 just for libgsasl1.8.0
+build_gsasl2() {
+ check_if_source_exist $GSASL2_SOURCE
+ cd $TP_SOURCE_DIR/$GSASL2_SOURCE
+ mkdir -p $BUILD_DIR && cd $BUILD_DIR
+ ../configure --prefix=$HDFS3_KRB5_INSTALL_DIR --with-gssapi-impl=mit --enable-shared=no --with-pic --with-libidn-prefix=$TP_INSTALL_DIR
Review Comment:
Where to define the `HDFS3_KRB5_INSTALL_DIR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gtchaos commented on a diff in pull request #9524: [Feature] libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
gtchaos commented on code in PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524#discussion_r876709031
##########
thirdparty/build-thirdparty.sh:
##########
@@ -904,16 +904,46 @@ build_gsasl() {
make -j $PARALLEL && make install
}
+# build_gsasl2 just for libgsasl1.8.0
+build_gsasl2() {
+ check_if_source_exist $GSASL2_SOURCE
+ cd $TP_SOURCE_DIR/$GSASL2_SOURCE
+ mkdir -p $BUILD_DIR && cd $BUILD_DIR
+ ../configure --prefix=$HDFS3_KRB5_INSTALL_DIR --with-gssapi-impl=mit --enable-shared=no --with-pic --with-libidn-prefix=$TP_INSTALL_DIR
Review Comment:
vars.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9524: libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524#issuecomment-1124984917
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9524: [Feature] libhdfs3 built enable kerberos support
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9524:
URL: https://github.com/apache/incubator-doris/pull/9524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org