[GitHub] [hadoop-ozone] swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.

[GitBox <gi...@apache.org>]

swagle commented on a change in pull request #23: HDDS-1868. Ozone pipelines should be marked as ready only after the leader election is complete.
URL: https://github.com/apache/hadoop-ozone/pull/23#discussion_r335654012
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
 ##########
 @@ -598,6 +605,9 @@ public boolean isExist(HddsProtos.PipelineID pipelineId) {
       for (RaftGroupId groupId : gids) {
         reports.add(PipelineReport.newBuilder()
             .setPipelineID(PipelineID.valueOf(groupId.getUuid()).getProtobuf())
+            .setLeaderID(leaderIdMap.containsKey(groupId) ?
+                ByteString.copyFromUtf8(leaderIdMap.get(groupId).toString()) :
 
 Review comment:
   Problem is again shaded ratis ByteString vs google Bytestring. 
   So I change the Map to hold ByteString and use that, lookup are cheap though, IMO we are nit-picking :=)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org