You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/02/03 18:00:45 UTC
Re: Review Request 17157: Add a 3rd argument to functional test
RunTests.java to allow a timeout factor for mapred.task.timeout and run.py
-f flag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17157/#review32433
-----------------------------------------------------------
test/src/main/java/org/apache/accumulo/test/functional/RunTests.java
<https://reviews.apache.org/r/17157/#comment62873>
if you just make the parameter annotaed variable an integer, jcommander will take care of parsing and giving a suitable error message on format exceptions.
test/src/main/java/org/apache/accumulo/test/functional/RunTests.java
<https://reviews.apache.org/r/17157/#comment61267>
can you fix this spacing to be 2 per indent?
test/src/main/java/org/apache/accumulo/test/functional/RunTests.java
<https://reviews.apache.org/r/17157/#comment62874>
if you just make the parameter annotaed variable an integer, jcommander will take care of parsing and giving a suitable error message on format exceptions.
- Sean Busbey
On Jan. 21, 2014, 10:11 p.m., Hung Pham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17157/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 10:11 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2005
> https://issues.apache.org/jira/browse/ACCUMULO-2005
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2005: Add a 3rd argument to functional test RunTests.java to allow a timeout factor for mapred.task.timeout and run.py -f flag
>
>
> Diffs
> -----
>
> test/src/main/java/org/apache/accumulo/test/functional/RunTests.java 91ee66e
> test/system/auto/README 7d18e8b
>
> Diff: https://reviews.apache.org/r/17157/diff/
>
>
> Testing
> -------
>
> Testing was done on small 5-nodes cluster to ensure MR job complete successfully instead of failing out due to timeouts that lead to killed attempts.
>
>
> Thanks,
>
> Hung Pham
>
>