You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/02/12 23:42:38 UTC
Review Request 69964: Added tests related to operation feedback agent
capabilities.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/
-----------------------------------------------------------
Review request for mesos and Gastón Kleiman.
Bugs: MESOS-9535
https://issues.apache.org/jira/browse/MESOS-9535
Repository: mesos
Description
-------
These tests verify that master and agent behavior is correct
during a downgrade of an agent to one which does not have the
AGENT_OPERATION_FEEDBACK capability, and when a new agent's
capabilities are altered such that it no longer has the
RESOURCE_PROVIDER capability set.
Diffs
-----
src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
Diff: https://reviews.apache.org/r/69964/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Feb. 13, 2019, 1:49 a.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9753 (patched)
> > <https://reviews.apache.org/r/69964/diff/1/?file=2124998#file2124998line9753>
> >
> > Can we check here that the framework doesn't get any operation status updates?
Since the test drops `UpdateOperationStatusMessage`s in order to simulate an old agent, I don't think this is a meaningful thing to do here. Dropping.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212779
-----------------------------------------------------------
On Feb. 12, 2019, 11:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 11:42 p.m.)
>
>
> Review request for mesos and Gastón Kleiman.
>
>
> Bugs: MESOS-9535
> https://issues.apache.org/jira/browse/MESOS-9535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
>
>
> Diff: https://reviews.apache.org/r/69964/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212779
-----------------------------------------------------------
src/tests/master_tests.cpp
Lines 9753 (patched)
<https://reviews.apache.org/r/69964/#comment298687>
Can we check here that the framework doesn't get any operation status updates?
- Gastón Kleiman
On Feb. 12, 2019, 3:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 3:42 p.m.)
>
>
> Review request for mesos and Gastón Kleiman.
>
>
> Bugs: MESOS-9535
> https://issues.apache.org/jira/browse/MESOS-9535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
>
>
> Diff: https://reviews.apache.org/r/69964/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212776
-----------------------------------------------------------
PASS: Mesos patch 69964 was successfully built and tested.
Reviews applied: `['69958', '69957', '69876', '69964']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2879/mesos-review-69964
- Mesos Reviewbot Windows
On Feb. 12, 2019, 11:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 11:42 p.m.)
>
>
> Review request for mesos and Gastón Kleiman.
>
>
> Bugs: MESOS-9535
> https://issues.apache.org/jira/browse/MESOS-9535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
>
>
> Diff: https://reviews.apache.org/r/69964/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212777
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_tests.cpp
Lines 9558 (patched)
<https://reviews.apache.org/r/69964/#comment298686>
Should we do `GET_OPERATIONS` here and check the response?
- Gastón Kleiman
On Feb. 12, 2019, 3:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 3:42 p.m.)
>
>
> Review request for mesos and Gastón Kleiman.
>
>
> Bugs: MESOS-9535
> https://issues.apache.org/jira/browse/MESOS-9535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
>
>
> Diff: https://reviews.apache.org/r/69964/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212813
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 12, 2019, 6:39 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:39 p.m.)
>
>
> Review request for mesos and Gastón Kleiman.
>
>
> Bugs: MESOS-9535
> https://issues.apache.org/jira/browse/MESOS-9535
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
>
>
> Diff: https://reviews.apache.org/r/69964/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69964: Added tests related to operation feedback
agent capabilities.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 2:39 a.m.)
Review request for mesos and Gastón Kleiman.
Bugs: MESOS-9535
https://issues.apache.org/jira/browse/MESOS-9535
Repository: mesos
Description
-------
These tests verify that master and agent behavior is correct
during a downgrade of an agent to one which does not have the
AGENT_OPERATION_FEEDBACK capability, and when a new agent's
capabilities are altered such that it no longer has the
RESOURCE_PROVIDER capability set.
Diffs (updated)
-----
src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e
Diff: https://reviews.apache.org/r/69964/diff/2/
Changes: https://reviews.apache.org/r/69964/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann