You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Rajesh (Jira)" <ji...@apache.org> on 2022/02/24 23:42:00 UTC
[jira] [Comment Edited] (HUDI-347) Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods
[ https://issues.apache.org/jira/browse/HUDI-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497806#comment-17497806 ]
Rajesh edited comment on HUDI-347 at 2/24/22, 11:41 PM:
--------------------------------------------------------
[~shivnarayan] the below 2 tests seem like a good place to start with well over a 100 lines of code each, do you agree.
private void testUpsertsInternal(HoodieWriteConfig config,
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>, String> writeFn, boolean isPrepped)
and
private void testUpsertsUpdatePartitionPath(IndexType indexType, HoodieWriteConfig config
and
testSmallInsertHandlingForUpserts
was (Author: JIRAUSER285685):
[~shivnarayan] the below 2 tests seem like a good place to start with well over a 100 lines of code each, do you agree.
private void testUpsertsInternal(HoodieWriteConfig config,
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>, String> writeFn, boolean isPrepped)
and
private void testUpsertsUpdatePartitionPath(IndexType indexType, HoodieWriteConfig config
> Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods
> ---------------------------------------------------------------------------
>
> Key: HUDI-347
> URL: https://issues.apache.org/jira/browse/HUDI-347
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Testing, writer-core
> Reporter: sivabalan narayanan
> Assignee: Rajesh
> Priority: Major
> Labels: new-to-hudi
> Original Estimate: 24h
> Remaining Estimate: 24h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)