You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/25 20:22:18 UTC
[GitHub] [kafka] Moovlin opened a new pull request, #12787: [WIP][KAFKA-14326] Removes excess white space surrounding topic input for S
Moovlin opened a new pull request, #12787:
URL: https://github.com/apache/kafka/pull/12787
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
The goal of the change is to remove excess white space surrounding topic inputs. As an example:
```
% ./kafka-streams-application-reset.sh --application-id streams-wordcount --bootstrap-servers <host>:9092 --input-topics " streams-plaintext-input, test" --to-earliest --force
Reset-offsets for input topics [ streams-plaintext-input, test]
Following input topics are not found, skipping them
Topic: streams-plaintext-input
Topic: test
Deleting inferred internal topics [streams-wordcount-KSTREAM-AGGREGATE-STATE-STORE-0000000003-repartition, streams-wordcount-KSTREAM-AGGREGATE-STATE-STORE-0000000003-changelog]
Done.
```
Despite the fact that the streams-plaintext-input topic does exist:
```
% ./kafka-topics.sh --bootstrap-server <host>:9092 --describe --topic streams-plaintext-input
Topic: streams-plaintext-input TopicId: 2e7WtMnHRrShhT2F7qq7xA PartitionCount: 1 ReplicationFactor: 1 Configs: min.insync.replicas=1,segment.bytes=1073741824,retention.ms=604800000,max.message.bytes=1000000,min.cleanable.dirty.ratio=0.5,unclean.leader.election.enable=false,retention.bytes=-1,delete.retention.ms=604800000
Topic: streams-plaintext-input Partition: 0 Leader: 1546334494 Replicas: 1546334494 Isr: 1546334494
```
This should instead trim the excess white space around the input topics and search for them.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
Currently, I've been running this change against a cluster I have access to as a means to test against it. But, I believe there should be tests for the command line tools. Where these tests are, I'm unsure. Perhaps they have to be built.
I opened this as a WIP to receive input on if there are other areas where these should be trimmed or if the "correct" way is to sift through and better understand how things like the TopicCommand are trimming inputs and then implementing that, presumably, more standardized process in the StreamsResetter code?
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][KAFKA-14326] StreamsRestter trim excess white space surrounding topic input [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12787: [WIP][KAFKA-14326] StreamsRestter trim excess white space surrounding topic input
URL: https://github.com/apache/kafka/pull/12787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][KAFKA-14326] StreamsRestter trim excess white space surrounding topic input [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12787:
URL: https://github.com/apache/kafka/pull/12787#issuecomment-2563279843
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #12787: [WIP][KAFKA-14326] StreamsRestter trim excess white space surrounding topic input
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12787:
URL: https://github.com/apache/kafka/pull/12787#issuecomment-1649012604
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org