You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/31 12:13:01 UTC
[GitHub] flink pull request #4027: [FLINK-6752] Apply non-invasive checkstyle rules t...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4027
[FLINK-6752] Apply non-invasive checkstyle rules to flink-core
This PR applies 3 non-invasive checkstyle rules to flink-core. It reorders imports, adds an empty line before the package declaration and removes multiple subsequent empty lines.
Note that the actual checkstyle enforcement in flink-core wasn't changed. The above checks should be added to the default checkstyle once we've applied PRs like this for the remaining modules.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6752cscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4027
----
commit 9e0b54188dbd3e6125204b036f87344d0496d01f
Author: zentol <ch...@apache.org>
Date: 2017-05-31T11:56:45Z
imports generated
commit 3c10edf5d6e9641cdff95dc8daa6471cc003170f
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:01:52Z
imports /main
commit 68e93bef2cd22a919777c4fa4f659acee9436a97
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:02:14Z
imports /test
commit 2f765f00f482057a7e8e56c5875318c563525fcc
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:04:19Z
add missing line before package
commit 63dff16ec125a614e7b9054dd95f92d63429863c
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:06:47Z
multi-empty line generated
commit 7592b91875fc0bfa613a7f5118b2b99cac6f89e6
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:11:03Z
multi-empty line /main
commit fdfe2288bdcd3c76c64cd3e56a1b5323c433bfc2
Author: zentol <ch...@apache.org>
Date: 2017-05-31T12:11:16Z
multi-empty line /test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4027: [FLINK-6752] Apply non-invasive checkstyle rules to flink...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4027
After looking into the remaining modules a bit i think we could safely merge a full checkstyle commit for all modules but flink-runtime, contrary to my previous comments in the JIRA. Core, java, optimizer and tests are actually rather stale in terms of modifications; we primarily add things to them which typically doesn't result in conflicts.
For runtime I'm currently thinking of applying the full checkstyle one package at a time; there's way to many threads going on in there to globally introduce most rules at once; although there are some exceptions like adding an empty line before the package declaration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4027: [FLINK-6752] Apply non-invasive checkstyle rules to flink...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4027
Closing this for now. Maybe we could use the approach for flink-runtime also for flink-core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4027: [FLINK-6752] Apply non-invasive checkstyle rules to flink...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4027
How much value is there in keeping the checkstyle changes to a single commit per module? It would mean fewer rebase conflicts for outstanding PRs and WIPs. The long-running tickets for large modules could be worked on in a feature branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4027: [FLINK-6752] Apply non-invasive checkstyle rules t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---