You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/12/10 08:04:31 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-268 : Adding Data Valida...

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/262#issuecomment-163519458
  
    My main concern with this PR is performances:
    * We are parsing the full data to make sure it fit the graph format
    * The validate function is launched a lot of times, even when not needed (COMMIT_PARAGRAPH after updated the width of the paragraph for example)
    
    We are already limited in term of memory in the web browser. Inspection with ng-stats or batarang didn't really help me getting a better idea on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---