[GitHub] [hadoop] aajisaka commented on a change in pull request #2519: YARN-10491: Fix deprecation warnings in SLSWebApp.java

[GitBox <gi...@apache.org>]

aajisaka commented on a change in pull request #2519:
URL: https://github.com/apache/hadoop/pull/2519#discussion_r535999377



##########
File path: hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java
##########
@@ -54,6 +54,7 @@
 @Unstable
 public class SLSWebApp extends HttpServlet {
   private static final long serialVersionUID = 1905162041950251407L;
+  private static final Charset UTF8 = Charset.forName("UTF-8");

Review comment:
       If you use `Charset.forName(String)`, you need to catch some exceptions. We can avoid catching exceptions by using `StandardCharsets.UTF-8`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org